Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output Heat to Power Conversion Efficiency [v3.7.3] #330

Merged
merged 21 commits into from
Jan 23, 2025

Conversation

softwareengineerprogrammer
Copy link
Collaborator

@softwareengineerprogrammer softwareengineerprogrammer commented Jan 22, 2025

Output average of First Law Efficiency over project lifetime as Heat to Power Conversion Efficiency in SURFACE EQUIPMENT SIMULATION RESULTS:

image

Additional/ancillary changes:

  1. Added tooltip text for First Law Efficiency and Heat to Power Conversion Efficiency; added Description column to Output Parameters RST so the tooltips are shown in docs:
    image
  2. Added SurfacePlant._calculate_derived_outputs as mechanism to calculate the output
  3. Fixed floating point error in schema generation
  4. Addressed longstanding TODO re: regenerating test case CSV

Initially self-reviewed in softwareengineerprogrammer#44

…t is calculated in _calculate_derived_outputs.
…ciency-2

Output Heat to Power Conversion Efficiency
Copy link
Collaborator

@jeffbourdier jeffbourdier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me.

@softwareengineerprogrammer softwareengineerprogrammer merged commit 7303de4 into NREL:main Jan 23, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants