Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI; documentation updates; parameter range exception handling #66

Merged
merged 27 commits into from
Dec 1, 2023
Merged

CLI; documentation updates; parameter range exception handling #66

merged 27 commits into from
Dec 1, 2023

Conversation

softwareengineerprogrammer
Copy link
Collaborator

  • Adds __main__.py to simplify calling from command line - includes corresponding update in README
  • Various documentation updates
  • Throw exception when parameters outside of allowable range instead of merely exiting

@softwareengineerprogrammer softwareengineerprogrammer marked this pull request as ready for review November 22, 2023 15:46
@softwareengineerprogrammer softwareengineerprogrammer added documentation Improvements or additions to documentation enhancement New feature or improvement (as opposed to bug/problem) labels Nov 22, 2023
@softwareengineerprogrammer softwareengineerprogrammer mentioned this pull request Nov 30, 2023
Closed
@softwareengineerprogrammer softwareengineerprogrammer linked an issue Nov 30, 2023 that may be closed by this pull request
Fix/enable Wanju_Yuan_Closed-Loop_Geothermal_Energy_Recovery.txt unit test case #16
Closed
softwareengineerprogrammer
softwareengineerprogrammer commented Nov 30, 2023
View reviewed changes
README.rst
- `SUTRAExample1.txt <tests/examples/SUTRAExample1.txt>`__
- `example_multiple_gradients.txt <tests/examples/example_multiple_gradients.txt>`__


Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO add running MC & HIP RA - #69

malcolm-dsider
malcolm-dsider approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@malcolm-dsider malcolm-dsider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ship it!

@softwareengineerprogrammer softwareengineerprogrammer merged commit 0f71703 into NREL:main Dec 1, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malcolm-dsider malcolm-dsider malcolm-dsider approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or improvement (as opposed to bug/problem)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix/enable Wanju_Yuan_Closed-Loop_Geothermal_Energy_Recovery.txt unit test case
2 participants
@softwareengineerprogrammer @malcolm-dsider