Greenheart #259
Merged
Greenheart #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bayc
approved these changes
Feb 15, 2024
bayc
added a commit
to jaredthomas68/HOPP
that referenced
this pull request
Feb 15, 2024
* create place for greenheart * boundary distance test correct * add electrolyzer as dependency * add electrolyzer as dependency * add test for spacing component * make openmdao a requirement * include testing inputs * get initial electrolyzer rating from input config dict * create hopp structure for greenheart * move hopp_tools_test.py to greenheart test directory * include greenheart init files and additional test input files --------- Co-authored-by: Chris Bay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make a place for Greenheart
This pull requests creates a new repository for Greenheart and adds it as an additional package installed along side HOPP. The Greenheart directory currently contains a single script that contains a set of OpenMDAO components for doing with farm layout optimization with HOPP. The components are: a HOPP wrapper, a boundary constraint, a turbine spacing constraint, and a wrapper to the NREL's electrolyzer.py model.
Related issue
This pull request is related to #231 in that it prepares a path forward for removing the
to_organizedirectory but does not resolve the issue.Impacted areas of the software
HOPP/greenheart/setup.pytests/greenheart/requirements.txtAdditional supporting information
In order for the tests to pass, I had to add OpenMDAO and electrolyzer.py as dependencies. The electrolyzer dependency is tied to a personal branch of the model that needs to get merged in. I will create a separate pull request for that branch on the proper repo and then I can update the dependency in HOPP.
Test results, if applicable
Passing.