Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProFAST Example #266

Merged
merged 4 commits into from
Jan 17, 2024
Merged

ProFAST Example #266

merged 4 commits into from
Jan 17, 2024

Conversation

kbrunik
Copy link
Collaborator

@kbrunik kbrunik commented Jan 17, 2024 •
edited
Loading

  • Added basic example detail how to use ProFAST within HOPP
  • Fixed required ProFAST imports

ProFAST is only compatible with python=3.8. Builds 3.9 and 3.10 in CI fail.

@kbrunik kbrunik requested a review from camirmas January 17, 2024 05:22
camirmas
camirmas approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@camirmas camirmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, merge when 3.8 build passes

@kbrunik kbrunik merged commit 43c1af4 into NREL:profast Jan 17, 2024
1 of 4 checks passed
@kbrunik kbrunik deleted the profast branch January 17, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camirmas camirmas camirmas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbrunik @camirmas