Adding Green Steel compressor test to greenheart tests #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredthomas68
requested changes
Mar 4, 2024
There was a problem hiding this comment.
After talking with Masha it sounds like we should try to check against a published source of our model rather than the Greensteel code as their values are pretty rough estimates.
kbrunik
force-pushed
the
greensteel-eco-sync
branch
from
bfabe2f to
299abf1
Compare
|
@kbrunik Per meeting, check value against HDSAM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the compressor capex test to sync up with Green Steel models and analysis