Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detailed constructions for surfaces #1366

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Detailed constructions for surfaces #1366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1d0c4de
Stub out schematron, HPXML classes, sample file.
shorowit Apr 19, 2023
5b826ce
Move thickness up a level; should apply to an entire construction lay…
shorowit Apr 19, 2023
0be8516
Latest results.
Apr 19, 2023
88ffada
First pass on implementation; handles above-grade walls and rim joists.
shorowit Apr 19, 2023
5e18b05
Merge branch 'detailed_constructions' of https://github.com/NREL/Open…
shorowit Apr 19, 2023
9943cd9
Bugfix.
shorowit Apr 20, 2023
14c593c
Latest results.
Apr 20, 2023
d202946
Add warning (and test) if provided assembly R-value is not close to c…
shorowit Apr 20, 2023
e16283f
Allow resistance-only layers. Implement code for roofs.
shorowit Apr 21, 2023
388206c
Fix CI tests
shorowit Apr 21, 2023
bb919e4
Latest results.
Apr 21, 2023
d47a244
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
shorowit May 1, 2023
3938ed0
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
shorowit May 3, 2023
9f4182b
Update XMLs
shorowit May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions BuildResidentialHPXML/measure.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.0</schema_version>
<name>build_residential_hpxml</name>
<uid>a13a8983-2b01-4930-8af2-42030b6e4233</uid>
<version_id>235c0e9c-de56-46b1-8712-83df120d39b8</version_id>
<version_modified>20230501T221652Z</version_modified>
<version_id>7e14b99a-8028-4045-a389-bc04982c8bdf</version_id>
<version_modified>20230503T221424Z</version_modified>
<xml_checksum>2C38F48B</xml_checksum>
<class_name>BuildResidentialHPXML</class_name>
<display_name>HPXML Builder</display_name>
Expand Down Expand Up @@ -6583,18 +6583,18 @@
</attribute>
</attributes>
<files>
<file>
<filename>geometry.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>D9E75C2E</checksum>
</file>
<file>
<filename>build_residential_hpxml_test.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>7F6A3D85</checksum>
</file>
<file>
<filename>geometry.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>5184329E</checksum>
</file>
<file>
<version>
<software_program>OpenStudio</software_program>
Expand Down
2 changes: 1 addition & 1 deletion BuildResidentialHPXML/resources/geometry.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def self.get_abs_azimuth(relative_azimuth, building_orientation)
def self.get_absolute_tilt(tilt_str, roof_pitch, epw_file)
tilt_str = tilt_str.downcase
if tilt_str.start_with? 'roofpitch'
roof_angle = Math.atan(roof_pitch / 12.0) * 180.0 / Math::PI
roof_angle = UnitConversions.convert(Math.atan(roof_pitch / 12.0), 'rad', 'deg')
return Float(eval(tilt_str.gsub('roofpitch', roof_angle.to_s)))
elsif tilt_str.start_with? 'latitude'
return Float(eval(tilt_str.gsub('latitude', epw_file.latitude.to_s)))
Expand Down
224 changes: 123 additions & 101 deletions HPXMLtoOpenStudio/measure.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,72 +399,80 @@ def self.add_roofs(runner, model, spaces)
next if surfaces.empty?

# Apply construction
has_radiant_barrier = roof.radiant_barrier
if has_radiant_barrier
radiant_barrier_grade = roof.radiant_barrier_grade
end
# FUTURE: Create Constructions.get_air_film(surface) method; use in measure.rb and hpxml_translator_test.rb
inside_film = Material.AirFilmRoof(Geometry.get_roof_pitch([surfaces[0]]))
outside_film = Material.AirFilmOutside
mat_roofing = Material.RoofMaterial(roof.roof_type)
if @apply_ashrae140_assumptions
inside_film = Material.AirFilmRoofASHRAE140
outside_film = Material.AirFilmOutsideASHRAE140
end
mat_int_finish = Material.InteriorFinishMaterial(roof.interior_finish_type, roof.interior_finish_thickness)
if mat_int_finish.nil?
fallback_mat_int_finish = nil
else
fallback_mat_int_finish = Material.InteriorFinishMaterial(mat_int_finish.name, 0.1) # Try thin material
end

install_grade = 1
assembly_r = roof.insulation_assembly_r_value
inside_film = roof.additional_properties.inside_film
outside_film = roof.additional_properties.outside_film

if not mat_int_finish.nil?
# Closed cavity
constr_sets = [
WoodStudConstructionSet.new(Material.Stud2x(8.0), 0.07, 20.0, 0.75, mat_int_finish, mat_roofing), # 2x8, 24" o.c. + R20
WoodStudConstructionSet.new(Material.Stud2x(8.0), 0.07, 10.0, 0.75, mat_int_finish, mat_roofing), # 2x8, 24" o.c. + R10
WoodStudConstructionSet.new(Material.Stud2x(8.0), 0.07, 0.0, 0.75, mat_int_finish, mat_roofing), # 2x8, 24" o.c.
WoodStudConstructionSet.new(Material.Stud2x6, 0.07, 0.0, 0.75, mat_int_finish, mat_roofing), # 2x6, 24" o.c.
WoodStudConstructionSet.new(Material.Stud2x4, 0.07, 0.0, 0.5, mat_int_finish, mat_roofing), # 2x4, 16" o.c.
WoodStudConstructionSet.new(Material.Stud2x4, 0.01, 0.0, 0.0, fallback_mat_int_finish, mat_roofing), # Fallback
]
match, constr_set, cavity_r = Constructions.pick_wood_stud_construction_set(assembly_r, constr_sets, inside_film, outside_film)
if roof.has_detailed_construction
# Layer-by-layer construction

Constructions.apply_detailed_construction(model, surfaces, roof.detailed_construction, inside_film,
outside_film, roof.solar_absorptance, roof.emittance)

Constructions.apply_closed_cavity_roof(model, surfaces, "#{roof.id} construction",
cavity_r, install_grade,
constr_set.stud.thick_in,
true, constr_set.framing_factor,
constr_set.mat_int_finish,
constr_set.osb_thick_in, constr_set.rigid_r,
constr_set.mat_ext_finish, has_radiant_barrier,
inside_film, outside_film, radiant_barrier_grade,
roof.solar_absorptance, roof.emittance)
else
# Open cavity
constr_sets = [
GenericConstructionSet.new(10.0, 0.5, nil, mat_roofing), # w/R-10 rigid
GenericConstructionSet.new(0.0, 0.5, nil, mat_roofing), # Standard
GenericConstructionSet.new(0.0, 0.0, nil, mat_roofing), # Fallback
]
match, constr_set, layer_r = Constructions.pick_generic_construction_set(assembly_r, constr_sets, inside_film, outside_film)
# Assembly R-value

cavity_r = 0
cavity_ins_thick_in = 0
framing_factor = 0
framing_thick_in = 0
has_radiant_barrier = roof.radiant_barrier
if has_radiant_barrier
radiant_barrier_grade = roof.radiant_barrier_grade
end
# FUTURE: Create Constructions.get_air_film(surface) method; use in measure.rb and hpxml_translator_test.rb
mat_roofing = Material.RoofMaterial(roof.roof_type)
mat_int_finish = Material.InteriorFinishMaterial(roof.interior_finish_type, roof.interior_finish_thickness)
if mat_int_finish.nil?
fallback_mat_int_finish = nil
else
fallback_mat_int_finish = Material.InteriorFinishMaterial(mat_int_finish.name, 0.1) # Try thin material
end

Constructions.apply_open_cavity_roof(model, surfaces, "#{roof.id} construction",
cavity_r, install_grade, cavity_ins_thick_in,
framing_factor, framing_thick_in,
constr_set.osb_thick_in, layer_r + constr_set.rigid_r,
constr_set.mat_ext_finish, has_radiant_barrier,
inside_film, outside_film, radiant_barrier_grade,
roof.solar_absorptance, roof.emittance)
install_grade = 1
assembly_r = roof.insulation_assembly_r_value

if not mat_int_finish.nil?
# Closed cavity
constr_sets = [
WoodStudConstructionSet.new(Material.Stud2x(8.0), 0.07, 20.0, 0.75, mat_int_finish, mat_roofing), # 2x8, 24" o.c. + R20
WoodStudConstructionSet.new(Material.Stud2x(8.0), 0.07, 10.0, 0.75, mat_int_finish, mat_roofing), # 2x8, 24" o.c. + R10
WoodStudConstructionSet.new(Material.Stud2x(8.0), 0.07, 0.0, 0.75, mat_int_finish, mat_roofing), # 2x8, 24" o.c.
WoodStudConstructionSet.new(Material.Stud2x6, 0.07, 0.0, 0.75, mat_int_finish, mat_roofing), # 2x6, 24" o.c.
WoodStudConstructionSet.new(Material.Stud2x4, 0.07, 0.0, 0.5, mat_int_finish, mat_roofing), # 2x4, 16" o.c.
WoodStudConstructionSet.new(Material.Stud2x4, 0.01, 0.0, 0.0, fallback_mat_int_finish, mat_roofing), # Fallback
]
match, constr_set, cavity_r = Constructions.pick_wood_stud_construction_set(assembly_r, constr_sets, inside_film, outside_film)

Constructions.apply_closed_cavity_roof(model, surfaces, "#{roof.id} construction",
cavity_r, install_grade,
constr_set.stud.thick_in,
true, constr_set.framing_factor,
constr_set.mat_int_finish,
constr_set.osb_thick_in, constr_set.rigid_r,
constr_set.mat_ext_finish, has_radiant_barrier,
inside_film, outside_film, radiant_barrier_grade,
roof.solar_absorptance, roof.emittance)
else
# Open cavity
constr_sets = [
GenericConstructionSet.new(10.0, 0.5, nil, mat_roofing), # w/R-10 rigid
GenericConstructionSet.new(0.0, 0.5, nil, mat_roofing), # Standard
GenericConstructionSet.new(0.0, 0.0, nil, mat_roofing), # Fallback
]
match, constr_set, layer_r = Constructions.pick_generic_construction_set(assembly_r, constr_sets, inside_film, outside_film)

cavity_r = 0
cavity_ins_thick_in = 0
framing_factor = 0
framing_thick_in = 0

Constructions.apply_open_cavity_roof(model, surfaces, "#{roof.id} construction",
cavity_r, install_grade, cavity_ins_thick_in,
framing_factor, framing_thick_in,
constr_set.osb_thick_in, layer_r + constr_set.rigid_r,
constr_set.mat_ext_finish, has_radiant_barrier,
inside_film, outside_film, radiant_barrier_grade,
roof.solar_absorptance, roof.emittance)
end
Constructions.check_surface_assembly_rvalue(runner, surfaces, inside_film, outside_film, assembly_r, match)
end
Constructions.check_surface_assembly_rvalue(runner, surfaces, inside_film, outside_film, assembly_r, match)
end
end

Expand Down Expand Up @@ -513,26 +521,31 @@ def self.add_walls(runner, model, spaces)
next if surfaces.empty?

# Apply construction
# The code below constructs a reasonable wall construction based on the
# wall type while ensuring the correct assembly R-value.

inside_film = Material.AirFilmVertical
if wall.is_exterior
outside_film = Material.AirFilmOutside
mat_ext_finish = Material.ExteriorFinishMaterial(wall.siding)
inside_film = wall.additional_properties.inside_film
outside_film = wall.additional_properties.outside_film

if wall.has_detailed_construction
# Layer-by-layer construction

Constructions.apply_detailed_construction(model, surfaces, wall.detailed_construction, inside_film,
outside_film, wall.solar_absorptance, wall.emittance)
else
outside_film = Material.AirFilmVertical
mat_ext_finish = nil
end
if @apply_ashrae140_assumptions
inside_film = Material.AirFilmVerticalASHRAE140
outside_film = Material.AirFilmOutsideASHRAE140
end
mat_int_finish = Material.InteriorFinishMaterial(wall.interior_finish_type, wall.interior_finish_thickness)
# Assembly R-value
# The code below constructs a reasonable wall construction based on the
# wall type while ensuring the correct assembly R-value.

Constructions.apply_wall_construction(runner, model, surfaces, wall.id, wall.wall_type, wall.insulation_assembly_r_value,
mat_int_finish, inside_film, outside_film, mat_ext_finish, wall.solar_absorptance,
wall.emittance)
if wall.is_exterior
mat_ext_finish = Material.ExteriorFinishMaterial(wall.siding)
else
mat_ext_finish = nil
end
mat_int_finish = Material.InteriorFinishMaterial(wall.interior_finish_type, wall.interior_finish_thickness)

Constructions.apply_wall_construction(runner, model, surfaces, wall.id, wall.wall_type, wall.insulation_assembly_r_value,
mat_int_finish, inside_film, outside_film, mat_ext_finish, wall.solar_absorptance,
wall.emittance)
end
end
end

Expand Down Expand Up @@ -578,33 +591,42 @@ def self.add_rim_joists(runner, model, spaces)

# Apply construction

inside_film = Material.AirFilmVertical
if rim_joist.is_exterior
outside_film = Material.AirFilmOutside
mat_ext_finish = Material.ExteriorFinishMaterial(rim_joist.siding)
inside_film = rim_joist.additional_properties.inside_film
outside_film = rim_joist.additional_properties.outside_film

if rim_joist.has_detailed_construction
# Layer-by-layer construction

Constructions.apply_detailed_construction(model, surfaces, rim_joist.detailed_construction, inside_film,
outside_film, rim_joist.solar_absorptance, rim_joist.emittance)
else
outside_film = Material.AirFilmVertical
mat_ext_finish = nil
end
# Assembly R-value

if rim_joist.is_exterior
mat_ext_finish = Material.ExteriorFinishMaterial(rim_joist.siding)
else
mat_ext_finish = nil
end

assembly_r = rim_joist.insulation_assembly_r_value

constr_sets = [
WoodStudConstructionSet.new(Material.Stud2x(2.0), 0.17, 20.0, 2.0, nil, mat_ext_finish), # 2x4 + R20
WoodStudConstructionSet.new(Material.Stud2x(2.0), 0.17, 10.0, 2.0, nil, mat_ext_finish), # 2x4 + R10
WoodStudConstructionSet.new(Material.Stud2x(2.0), 0.17, 0.0, 2.0, nil, mat_ext_finish), # 2x4
WoodStudConstructionSet.new(Material.Stud2x(2.0), 0.01, 0.0, 0.0, nil, mat_ext_finish), # Fallback
]
match, constr_set, cavity_r = Constructions.pick_wood_stud_construction_set(assembly_r, constr_sets, inside_film, outside_film)
install_grade = 1

Constructions.apply_rim_joist(model, surfaces, "#{rim_joist.id} construction",
cavity_r, install_grade, constr_set.framing_factor,
constr_set.mat_int_finish, constr_set.osb_thick_in,
constr_set.rigid_r, constr_set.mat_ext_finish,
inside_film, outside_film, rim_joist.solar_absorptance,
rim_joist.emittance)
Constructions.check_surface_assembly_rvalue(runner, surfaces, inside_film, outside_film, assembly_r, match)
assembly_r = rim_joist.insulation_assembly_r_value

constr_sets = [
WoodStudConstructionSet.new(Material.Stud2x(2.0), 0.17, 20.0, 2.0, nil, mat_ext_finish), # 2x4 + R20
WoodStudConstructionSet.new(Material.Stud2x(2.0), 0.17, 10.0, 2.0, nil, mat_ext_finish), # 2x4 + R10
WoodStudConstructionSet.new(Material.Stud2x(2.0), 0.17, 0.0, 2.0, nil, mat_ext_finish), # 2x4
WoodStudConstructionSet.new(Material.Stud2x(2.0), 0.01, 0.0, 0.0, nil, mat_ext_finish), # Fallback
]
match, constr_set, cavity_r = Constructions.pick_wood_stud_construction_set(assembly_r, constr_sets, inside_film, outside_film)
install_grade = 1

Constructions.apply_rim_joist(model, surfaces, "#{rim_joist.id} construction",
cavity_r, install_grade, constr_set.framing_factor,
constr_set.mat_int_finish, constr_set.osb_thick_in,
constr_set.rigid_r, constr_set.mat_ext_finish,
inside_film, outside_film, rim_joist.solar_absorptance,
rim_joist.emittance)
Constructions.check_surface_assembly_rvalue(runner, surfaces, inside_film, outside_film, assembly_r, match)
end
end
end

Expand Down
Loading