Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unavailable period less than 24 hours #1921

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

joseph-robertson
Copy link
Collaborator

@joseph-robertson joseph-robertson commented Feb 5, 2025

Pull Request Description

Checklist:

  • Update schedules.rb's set_unavailable_periods method
    • change "outage" to "unavailable"
    • refactor all the duplicate code
  • Add simple schedule unit tests for 12/14 20 - 12/15 6

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@joseph-robertson joseph-robertson self-assigned this Feb 5, 2025
@joseph-robertson joseph-robertson changed the title Support 2 schedule rules for unavailable period less than 24 hours Fix unavailable period less than 24 hours Feb 5, 2025
@joseph-robertson joseph-robertson marked this pull request as ready for review February 6, 2025 18:31
Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes to results, nice code cleanup, new tests. LGTM, thanks @joseph-robertson!

@shorowit shorowit merged commit fe64eb4 into master Feb 6, 2025
@shorowit shorowit deleted the fix-2-day-partial-unavailable-period branch February 6, 2025 22:18
@willf willf mentioned this pull request Feb 12, 2025
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants