Adjust node connections

cf #5326 (comment)
NREL · Jan 9, 2025 · 373c394 · 373c394
1 parent 292a5d4
commit 373c394
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 10 deletions.
diff --git a/src/energyplus/ForwardTranslator/ForwardTranslateZoneHVACEvaporativeCoolerUnit.cpp b/src/energyplus/ForwardTranslator/ForwardTranslateZoneHVACEvaporativeCoolerUnit.cpp
@@ -63,21 +63,29 @@ namespace energyplus {
       idfObject.setString(ZoneHVAC_EvaporativeCoolerUnitFields::AvailabilityScheduleName, wo_->nameString());
     }
 
-    boost::optional<std::string> outdoorAirInletNodeName;
+    const auto outdoorAirInletNodeName = modelObject.nameString() + " Outdoor Air Node";
     boost::optional<std::string> coolerOutletNodeName;
 
-    // Outdoor Air Inlet Node Name: Required Node
-    if (boost::optional<Node> node = modelObject.inletNode()) {
-      outdoorAirInletNodeName = node->nameString();
-      idfObject.setString(ZoneHVAC_EvaporativeCoolerUnitFields::OutdoorAirInletNodeName, node->nameString());
+    // Outdoor Air Inlet Node Name: Required Node - This is an Outdoor Air Node
+    {
+      IdfObject oaNodeListIdf(openstudio::IddObjectType::OutdoorAir_NodeList);
+      oaNodeListIdf.setString(0, outdoorAirInletNodeName);
+      m_idfObjects.emplace_back(std::move(oaNodeListIdf));
+      idfObject.setString(ZoneHVAC_EvaporativeCoolerUnitFields::OutdoorAirInletNodeName, outdoorAirInletNodeName);
     }
 
-    // Cooler Outlet Node Name: Required Node
+    // Cooler Outlet Node Name: Required Node, a zone air inlet node
     if (boost::optional<Node> node = modelObject.outletNode()) {
       coolerOutletNodeName = node->nameString();
       idfObject.setString(ZoneHVAC_EvaporativeCoolerUnitFields::CoolerOutletNodeName, node->nameString());
     }
 
+    // Zone Relief Air Node Name: optional Node, filled to a Zone Exhaust Node if the flow is being balanced here and not elsewhere
+    if (boost::optional<Node> node = modelObject.inletNode()) {
+      coolerOutletNodeName = node->nameString();
+      idfObject.setString(ZoneHVAC_EvaporativeCoolerUnitFields::ZoneReliefAirNodeName, node->nameString());
+    }
+
     // Supply Air Fan Object Type
     // Supply Air Fan Name
     HVACComponent supplyAirFan_ = modelObject.supplyAirFan();
@@ -138,7 +146,7 @@ namespace energyplus {
     std::string baseName = modelObject.nameString();
     if (fan_) {
       std::string outletNodeName;
-      std::string inletNodeName = outdoorAirInletNodeName.get();
+      std::string inletNodeName = outdoorAirInletNodeName;
       if (istringEqual(fanPlacement, "BlowThrough")) {
         if (firstEvaporativeCooler_) {
           outletNodeName = baseName + " Fan - First Evaporative Cooler Node";
@@ -180,7 +188,7 @@ namespace energyplus {
       if (istringEqual(fanPlacement, "BlowThrough") && fan_) {
         inletNodeName = baseName + " Fan - First Evaporative Cooler Node";
       } else {
-        inletNodeName = outdoorAirInletNodeName.get();
+        inletNodeName = outdoorAirInletNodeName;
       }
 
       if (secondEvaporativeCooler_) {
@@ -212,7 +220,7 @@ namespace energyplus {
       } else if (istringEqual(fanPlacement, "BlowThrough") && fan_) {
         inletNodeName = baseName + " Fan - Second Evaporative Cooler Node";
       } else {
-        inletNodeName = outdoorAirInletNodeName.get();
+        inletNodeName = outdoorAirInletNodeName;
       }
 
       if (istringEqual(fanPlacement, "DrawThrough") && fan_) {

diff --git a/src/model/ZoneHVACEvaporativeCoolerUnit.cpp b/src/model/ZoneHVACEvaporativeCoolerUnit.cpp
@@ -122,7 +122,7 @@ namespace model {
     }
 
     unsigned ZoneHVACEvaporativeCoolerUnit_Impl::inletPort() const {
-      return OS_ZoneHVAC_EvaporativeCoolerUnitFields::OutdoorAirInletNodeName;
+      return OS_ZoneHVAC_EvaporativeCoolerUnitFields::ZoneReliefAirNodeName;
     }
 
     unsigned ZoneHVACEvaporativeCoolerUnit_Impl::outletPort() const {