Update to v22.1.0-IOFreeze #4540
Conversation
joseph-robertson
added
IDDChange
Pull Request - Ready for CI
| @@ -2800,7 +2800,7 @@ namespace detail { | |||
| // in 8.1 this is 'EnergyPlus-Windows-32 8.1.0.008, YMD=2014.11.08 22:49' | |||
| // in 8.2 this is 'EnergyPlus, Version 8.2.0-8397c2e30b, YMD=2015.01.09 08:37' | |||
| // radiance script is writing 'EnergyPlus, VERSION 8.2, (OpenStudio) YMD=2015.1.9 08:35:36' | |||
| boost::regex version_regex("\\d\\.\\d[\\.\\d]*"); | |||
| boost::regex version_regex("\\d{1,}\\.\\d[\\.\\d]*"); | |||
There was a problem hiding this comment.
@jmarrec Does this look right?
There was a problem hiding this comment.
Ah yeah right, the version change... I suppose it will always be a two digits year at the start. The minor (and patch but that's covered) versions are unlikely to get into the two digits though, but I'm not sure.
Pinging @Myoldmopar here... Could you let us know a bit more about the new versionning scheme for E+?
Side note: this may be a good opportunity to change this to a raw string litteral to avoid escaping like crazy, like so, though that may be my preference only (it's hard to read in any case, given that the parenthesis here are not a capturing group...)
boost::regex version_regex(R"(\d{2}\.\d[\.\d]*)");
It will be a two digit year for the major version and then a single digit minor version. I cannot fathom how we would get to a double digit minor version in a single year. |
There was a problem hiding this comment.
A surprisingly low amount of IDD changes (perhaps we got used to the major refactors like renaming fuel types and co in the last few versions), and no field inserted so no VT needed.
I saw you filed enhancement requests for the new objects, thanks for that.
I'm all good with this once the cmake adjustment for arm64 is done.
Thanks for the good work @joseph-robertson !
| @@ -6826,12 +6826,12 @@ namespace osversion { | |||
|
|
|||
| } // end update_3_2_1_to_3_3_0 | |||
|
|
|||
| std::string VersionTranslator::update_3_3_0_to_3_3_1(const IdfFile& idf_3_3_0, const IddFileAndFactoryWrapper& idd_3_3_1) { | |||
| std::string VersionTranslator::update_3_3_0_to_3_4_0(const IdfFile& idf_3_3_0, const IddFileAndFactoryWrapper& idd_3_4_0) { | |||
There was a problem hiding this comment.
Ok, no VT needed, all these fields were added at the end of the object (not inserted) and have a default, so no-op
Addresses #4531, breaking changes
|
CI Results for 313107d:
|
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.