feature: Option to Convert Quadratic Value Curves to PWL for Plexos Parser. Fix Reserve Units. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
- Coverage 61.41% 60.86% -0.56%
==========================================
Files 29 29
Lines 2978 3020 +42
==========================================
+ Hits 1829 1838 +9
- Misses 1149 1182 +33 ☔ View full report in Codecov by Sentry. |
ktehranchi
changed the title
pesap
approved these changes
Sep 25, 2024
There was an edge case where the date_from / date_to filter used a date in the middle of a study year. I resolved this filtering by filtering the property by the year listed in date_from date_to instead. I also added a note and ticket for future work to ensure partial year properties are added to `max_active_power`
- Cleans up code for field filtering, making more use of the helper function field_filter. - Adds new helper function for preparing ext data - Fixes bug with timestamp sorting in one type of csv file
ktehranchi
force-pushed
the
kt/curve_conversion
branch
from
b3f7186 to
c4e3ce1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where quadratic value curves have time-varying fuel costs associated with them, PSI wont be able to model Market Bid Cost with time-varying quadratic value curves. Here I implement the feature to convert quadratic value curves to PWL.
Usage: feature_flag
quad2pwl = number of tranches to fitOther Changes:
construct_reserves()to match other device construction fields... fixes potential error in old implementation which used pivot instead ofparse_property_data()function