update tests

NREL · Mar 11, 2024 · cb6d9d9 · cb6d9d9
1 parent 9fa0b68
commit cb6d9d9
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 77 deletions.
diff --git a/test/runtests.jl b/test/runtests.jl
@@ -1982,7 +1982,7 @@ else  # run HiGHS tests
                     end
                 end 
 
-                # TODO: refresh tests and test values as needed after Cambium update; revised values are in test_with_xpress.jl
+                # TODO: refresh tests and test values as needed once able to uncomment; revised values are in test_with_xpress.jl
                 # if i == 1
                 #     @test results["PV"]["size_kw"] ≈ 60.12 atol=1e-1
                 #     @test results["ElectricStorage"]["size_kw"] ≈ 0.0 atol=1e-1

diff --git a/test/test_with_xpress.jl b/test/test_with_xpress.jl
@@ -1377,82 +1377,6 @@ end
     @test calculated_ghp_capex ≈ reopt_ghp_capex atol=300
 end
 
-@testset "Cambium Emissions" begin
-    """
-    1) Location in contiguous US
-        - Correct data from Cambium (returned location and values)
-        - Adjusted for load year vs. Cambium year (which starts on Sunday) vs. AVERT year (2022 currently)
-        - co2 pct increase should be zero
-    2) HI and AK locations
-        - Should use AVERT data and give an "info" message
-        - Adjust for load year vs. AVERT year
-        - co2 pct increase should be the default value unless user provided value 
-    3) International 
-        - all emissions should be zero unless provided
-    """
-    m1 = Model(Xpress.Optimizer)
-    m2 = Model(Xpress.Optimizer)
-
-    post_name = "cambium.json" 
-    post = JSON.parsefile("./scenarios/$post_name")
-
-    cities = Dict(
-        "Denver" => (39.7413753050447, -104.99965032911328),
-        "Fairbanks" => (64.84053664406181, -147.71913656313163),
-        "Santiago" => (-33.44485437650408, -70.69031905547853)
-    )
-
-    # 1) Location in contiguous US
-    city = "Denver"
-    post["Site"]["latitude"] = cities[city][1]
-    post["Site"]["longitude"] = cities[city][2]
-    post["ElectricLoad"]["loads_kw"] = [20 for i in range(1,8760)]
-    post["ElectricLoad"]["year"] = 2021 # 2021 First day is Fri
-    scen = Scenario(post)
-
-    @test scen.electric_utility.avert_emissions_region == "Rocky Mountains"
-    @test scen.electric_utility.distance_to_avert_emissions_region_meters ≈ 0 atol=1e-5
-    @test scen.electric_utility.cambium_emissions_region == "RMPAc"
-    @test sum(scen.electric_utility.emissions_factor_series_lb_CO2_per_kwh) / 8760 ≈ 0.394608 rtol=1e-3
-    @test scen.electric_utility.emissions_factor_series_lb_CO2_per_kwh[1] ≈ 0.677942 rtol=1e-4 # Should start on Friday
-    @test scen.electric_utility.emissions_factor_series_lb_CO2_per_kwh[8760] ≈ 0.6598207198 rtol=1e-5 # Should end on Friday 
-    @test sum(scen.electric_utility.emissions_factor_series_lb_SO2_per_kwh) / 8760 ≈ 0.00061165 rtol=1e-5 # check avg from AVERT data for RM region
-    @test scen.electric_utility.emissions_factor_CO2_decrease_fraction ≈ 0 atol=1e-5 # should be 0 with Cambium data
-    @test scen.electric_utility.emissions_factor_SO2_decrease_fraction ≈ REopt.EMISSIONS_DECREASE_DEFAULTS["SO2"] # should be 2.163% for AVERT data
-    @test scen.electric_utility.emissions_factor_NOx_decrease_fraction ≈ REopt.EMISSIONS_DECREASE_DEFAULTS["NOx"]
-    @test scen.electric_utility.emissions_factor_PM25_decrease_fraction ≈ REopt.EMISSIONS_DECREASE_DEFAULTS["PM25"]
-
-    # 2) AK location
-    city = "Fairbanks"
-    post["Site"]["latitude"] = cities[city][1]
-    post["Site"]["longitude"] = cities[city][2]
-    scen = Scenario(post)
-
-    @test scen.electric_utility.avert_emissions_region == "Alaska"
-    @test scen.electric_utility.distance_to_avert_emissions_region_meters ≈ 0 atol=1e-5
-    @test scen.electric_utility.cambium_emissions_region == "NA - Cambium data not used for climate emissions"
-    @test sum(scen.electric_utility.emissions_factor_series_lb_CO2_per_kwh) / 8760 ≈ 1.29199999 rtol=1e-3 # check that data from eGRID (AVERT data file) is used
-    @test scen.electric_utility.emissions_factor_CO2_decrease_fraction ≈ REopt.EMISSIONS_DECREASE_DEFAULTS["CO2e"] # should get updated to this value
-    @test scen.electric_utility.emissions_factor_SO2_decrease_fraction ≈ REopt.EMISSIONS_DECREASE_DEFAULTS["SO2"] # should be 2.163% for AVERT data
-    @test scen.electric_utility.emissions_factor_NOx_decrease_fraction ≈ REopt.EMISSIONS_DECREASE_DEFAULTS["NOx"]
-    @test scen.electric_utility.emissions_factor_PM25_decrease_fraction ≈ REopt.EMISSIONS_DECREASE_DEFAULTS["PM25"]      
-
-    # 3) International location
-    city = "Santiago"
-    post["Site"]["latitude"] = cities[city][1]
-    post["Site"]["longitude"] = cities[city][2]
-    scen = Scenario(post)
-
-    @test scen.electric_utility.avert_emissions_region == ""
-    @test scen.electric_utility.distance_to_avert_emissions_region_meters ≈ 5.521032136418236e6 atol=1.0
-    @test scen.electric_utility.cambium_emissions_region == "NA - Cambium data not used for climate emissions"
-    @test sum(scen.electric_utility.emissions_factor_series_lb_CO2_per_kwh) ≈ 0 
-    @test sum(scen.electric_utility.emissions_factor_series_lb_NOx_per_kwh) ≈ 0 
-    @test sum(scen.electric_utility.emissions_factor_series_lb_SO2_per_kwh) ≈ 0 
-    @test sum(scen.electric_utility.emissions_factor_series_lb_PM25_per_kwh) ≈ 0 
-
-end
-
 @testset "Emissions and Renewable Energy Percent" begin
     #renewable energy and emissions reduction targets
     include_exported_RE_in_total = [true,false,true]