October 2024: Fixes for battery dispatch and ASHP sizing, Update for GHP District #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The if/else was changing require_ghp_purchase input to 0 if it was a binary 1 input. The input option of true/false (more conventional) still worked as intended.
…er techs for pre-run GHP It's a little strange, but we don't include GHP in techs.all because of some fundamental differences in constraints that apply to other techs vs GHP.
This reverts commit 353085f.
ghp-district
This reverts commit 2cb4b1d.
Prevent simultaneous charge/discharge plus other minor improvements
…/REopt.jl into fix-ashp-min-allowable-size
Fix ASHP min allowable size enforcement
Bill-Becker
changed the title
Bill-Becker
changed the title
zolanaj
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Approved, thanks @Bill-Becker!
Small reminder to change the version in Project.toml and the changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs: