-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ELM-based ordinance retrieval and extraction #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two additional comments and i'm not sure where they go:
- While running ords, we get an error:
AttributeError: None of the edge conditions from "init" were satisfied: [{'condition': <function llm_response_starts_with_yes at 0x12369cc10>}]
Maybe should say “This is not necessarily an error and may mean that the text does not have the requested data”
- Could we download the pdf’s to a subdir similar to how the logs are stored?
with open(fp, "w") as fh: | ||
json.dump(usage_info, fh, indent=4) | ||
|
||
logger.info("Total processing time: %s", total_time_str) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way we could add an additional log message somewhere around here stating "{} ordinances found for {county} {state}. Outputs are here: {}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup! Added this and also a message if no ordinance values are found at all.
Co-authored-by: Grant Buster <[email protected]>
Co-authored-by: Grant Buster <[email protected]>
Co-authored-by: Grant Buster <[email protected]>
Yup! Added both. |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
ELM-based ordinance retrieval and extraction
Add code to support ELM paper.
Notes