Add skip_init option to SerdeAPI from_* methods
#123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarow
commented
May 6, 2024
| @@ -859,7 +859,7 @@ def copy_vehicle(veh: Vehicle, return_type: str = None, deep: bool = True) -> Di | |||
| veh_dict = {key: to_native_type(veh_dict[key]) for key in veh_dict if key not in [ | |||
| "large_baseline_eff", "small_baseline_eff"]} | |||
| veh_yaml = yaml.dump(veh_dict) | |||
| v = RustVehicle.from_yaml(veh_yaml) | |||
| v = RustVehicle.from_yaml(veh_yaml, skip_init=True) | |||
There was a problem hiding this comment.
@calbaker This did end up fixing the issue!!
There was a problem hiding this comment.
Sweet! Looks like you ended up covering all the from_ cases, right? I'm going to go ahead and approve.
calbaker
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to skip initialization to resolve https://github.nrel.gov/MBAP/fastsim/issues/319