Generate variable paths #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cbaker2 I created a unit test testing the function output against what I think is the complete output for a fastsim Vehicle. Does the list I'm comparing the output to look good to you, or is it missing anything (the test passes, so if there is something missing, that means the function is not working properly yet)? |
updated path based on Kyle's changes turned off some getters/setters because they trigger `todo!()`
calbaker
reviewed
Jul 11, 2024
|
|
||
| # load 2012 Ford Fusion from file | ||
| veh = fsim.Vehicle.from_file( | ||
| str(fsim.package_root() / "../../tests/assets/2016_TOYOTA_Prius_Two.yaml") |
There was a problem hiding this comment.
@robinsteuteville , switched to the prius to see if it'll work on HEVs, and there is an error with None, perhaps the same as what you encountered in ALTRIOS.
|
superseded by #147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.