Update CI Workflow to Skip Network Tests #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 2, 2024 15:43
This commit works off of an environmental variable called 'FASTSIM_DISABLE_NETWORK_TESTS'. If this variable is set (regardless of the value), then networking tests will be skipped. Within the code, the environment variable is referenced via the constant NETWORK_TEST_DISABLE_ENV_VAR_NAME. If 'FASTSIM_DISABLE_NETWORK_TESTS' is set, the test will print to console and exit (i.e., it will show as passing). A user will need to run `cargo test -- --nocapture` to see the print statements that the test has been skipped.
The code to run the demo tests starts a subprocess. However, that python version may not have the required libraries installed if FASTSim had been installed to a virtual environment. This change makes it such that we use the current python executable to also run the demo tests. If that executable doesn't resolve (empty string or None), then we default to just "python" and hope it is on the path (and set up with FASTSim).
Was missing from the tests.yaml file. Also fixed spacing issue.
michael-okeefe
added
bug
calbaker
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets an environment variable in the CI to skip tests that require network access since the network unreliability on the CI can cause false positive failures.
This commit also addresses an issue where demo tests were not running when called from a venv that had FASTSim installed.
NOTE: there was a previous version of this PR that accidentally brought in the v2.1.3 changes as well. That was deleted and this one was made.