Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleBattery parameterized for simple LDES modeling #136

Draft
wants to merge 48 commits into
base: develop
Choose a base branch
from
Draft

SimpleBattery parameterized for simple LDES modeling #136

wants to merge 48 commits into from
+122,552 −43

Conversation

ZackTully
Copy link
Collaborator

Adding features to the SimpleBattery model that will help with simple LDES modeling.

Modeling features added:

  1. Charging/discharging efficiency function
  2. Self-discharge
  3. Simple degradation model using rainflow counting

To Do

  1. Write tests
  2. Make example highlighting the new features.

paulf81 and others added 30 commits November 20, 2024 10:05
@paulf81
Rename readme
7482bb3
@paulf81
readme to md
9d67279
@paulf81
Clean up run scripts
bc3580d
@paulf81
Merge branch 'develop' into feature/standard_example
9ce83d2
@paulf81
Remove example 2
50e1f6c
@paulf81
update runscript and readme
6bc5a84
@paulf81
Update readmes
7f0009b
@paulf81
Update run script
61400c4
@paulf81
update readme and runscript
a0e6736
@paulf81
update run scripts
e5ffd78
@paulf81
re-org example 7
685dbd7
@paulf81
rename example 5
4d72ff9
@paulf81
rename example 8
1ce747e
@paulf81
set sim to 20 s
b766429
@paulf81
Update output vis
15ea201
@paulf81
move amr_input
046b28e
@paulf81
delete unnecessary rm
4d843f4
@paulf81
update README
f1329d3
@paulf81
temp move amr-openfast to be adjacent to amr cases
d8cccf8
@paulf81
update readme and runscript
fccf59a
@paulf81
organize inputs
7d75b0d
@paulf81
reinclude input csv
f1a7ffc
@genevievestarke
Updating electrolyzer example to work with electrolyzer develop branch
d93f9bb
changing generate_amr_wind_standin_data to work with the other standi…
3650720 
…n examples
@misi9170
Merge branch 'develop' into feature/standard_example
afb4db8
@misi9170
Add back input data for example 10.
2e16b76
@misi9170
Fix issues with example 10 (mainly, enable power return from either S…
d6c84b2 
…impleSolar or SolarPySAM)
@paulf81
Add plot outputs
773b6eb
@paulf81
remove all python 3
08864c9
@paulf81
Update run_script
0fd0d95
paulf81 and others added 18 commits November 22, 2024 11:42
@paulf81
Update outputs
adcab20
@paulf81
long line
1eed659
@paulf81
ruff
63937c3
@paulf81
Update example 01
8269df5
@genevievestarke
Update Example 05 README
ea85de7
Update example 06 run_script to generate standin data and output dire…
44d4870 
…ctory management
Change emulator.py to not call py_sims.step when there are no py_sims…
80ca2bd 
… in the hercules input yaml
Copied solar_pysam_test.py input file to test_inputs folder instead o…
0367082 
…f example 07
@paulf81
Renumber AMR examples
cff75b9
@paulf81
Update 06 outputs
d7c6a15
@paulf81
Try editing batch
67a423b
@paulf81
Add helics killer
1503bd8
@paulf81
Update kestrel run scripts
1058576
charging efficiency loss added to simple battery
33888a2
Fixing battery_test
c461423
self-discharge, chargingin efficiency curve, degradation effect
9ad80b6
Merge remote-tracking branch 'upstream/develop' into feature/simple_b…
4c1d221 
…attery_improvements
merged with upstream/develop
6ea60f8
@ZackTully ZackTully added the enhancement New feature or request label Jan 26, 2025
@ZackTully ZackTully self-assigned this Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulf81 paulf81 Awaiting requested review from paulf81

@genevievestarke genevievestarke Awaiting requested review from genevievestarke

Assignees

@ZackTully ZackTully

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZackTully @paulf81 @genevievestarke @misi9170