fix: Allowing serialization with numpy types inside of BaseQuantity
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
==========================================
+ Coverage 96.06% 96.11% +0.04%
==========================================
Files 36 36
Lines 2976 2988 +12
==========================================
+ Hits 2859 2872 +13
+ Misses 117 116 -1 ☔ View full report in Codecov by Sentry. |
daniel-thom
reviewed
Jan 21, 2025
src/infrasys/base_quantity.py
Outdated
| @@ -79,6 +79,8 @@ def to_dict(self) -> dict[str, Any]: | |||
| val = self.magnitude | |||
| if isinstance(self.magnitude, np.ndarray): | |||
| val = self.magnitude.tolist() | |||
| if isinstance(self.magnitude, np.generic): | |||
There was a problem hiding this comment.
Would this ever conflict with the previous conditional? Should it be elif instead of if?
There was a problem hiding this comment.
Good call. I will make it elif
daniel-thom
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that you can create a
pint.Quantiyusing a numpy type. This PR allows ours custom serialization to cast the numpy types to its python equivalent using.item()from numpy.