-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-transient dwelling unit energy recovery ventilation #1165
Merged
Merged
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
37ea6eb
Add ERR to effectiveness conversion as well as ERR scaling.
lymereJ 7e9e0a9
Merge branch '901_2016_2019' into 90.1-2019_ay-2016_ce
lymereJ 9e2fb7c
Merge branch 'master' into 90.1-2019_ay-2016_ce
lymereJ 2dbaf6f
add ERV for nontransient dwelling units
yunyang-ye efa24c4
fix one error about criteria to search variables
yunyang-ye 8a23fcd
update script to fix some issues
yunyang-ye b10fa00
update a file based on rubocop check
fb371f8
sort zones to avoid random sequence of light shutoff control naming
leijerry888 9fd667d
resolve the duplicates in the spreadsheet
yunyang-ye d7ffa38
add necessary YARD comments
yunyang-ye dee1de6
Refactor proposed changes. Standalone ERV is added for residential pr…
lymereJ dc1e5eb
Fix missing refrences.
lymereJ 7f77f36
Address editorial comments, and change the midrise apartment system t…
lymereJ 0fd7df8
Missing formatting issue.
lymereJ 29021d8
Merge dev branch in.
lymereJ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -86,4 +86,41 @@ def heat_exchanger_air_to_air_sensible_and_latent_apply_prototype_efficiency(hea | |
|
||
return true | ||
end | ||
|
||
# Set sensible and latent effectiveness at 100 and 75 heating and cooling airflow; | ||
# The values are calculated by using ERR, which is introduced in 90.1-2016 Addendum CE | ||
# | ||
# This function is only used for nontransient dwelling units (Mid-rise and High-rise Apartment) | ||
# @param [OpenStudio::Model::HeatExchangerAirToAirSensibleAndLatent] heat exchanger air to air sensible and latent | ||
# @param [String] err | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. parameters not fully explained / specified |
||
# @param [String] err basis (Cooling/Heating) | ||
# @param [String] climate zone | ||
def heat_exchanger_air_to_air_sensible_and_latent_apply_prototype_efficiency_err(heat_exchanger_air_to_air_sensible_and_latent, err, basis, climate_zone) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. even though the method name is long, avoid acronyms ('err') in method names |
||
# Assumed to be sensible and latent at all flow | ||
if err.nil? | ||
full_htg_sens_eff = 0.0 | ||
full_htg_lat_eff = 0.0 | ||
part_htg_sens_eff = 0.0 | ||
part_htg_lat_eff = 0.0 | ||
full_cool_sens_eff = 0.0 | ||
full_cool_lat_eff = 0.0 | ||
part_cool_sens_eff = 0.0 | ||
part_cool_lat_eff = 0.0 | ||
else | ||
err = enthalpy_recovery_ratio_design_to_typical_adjustment(err, climate_zone) | ||
full_htg_sens_eff, full_htg_lat_eff, part_htg_sens_eff, part_htg_lat_eff, full_cool_sens_eff, full_cool_lat_eff, part_cool_sens_eff, part_cool_lat_eff = heat_exchanger_air_to_air_sensible_and_latent_enthalpy_recovery_ratio_to_effectiveness(err, basis) | ||
end | ||
|
||
heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat100HeatingAirFlow(full_htg_sens_eff) | ||
heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat100HeatingAirFlow(full_htg_lat_eff) | ||
heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat75HeatingAirFlow(part_htg_sens_eff) | ||
heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat75HeatingAirFlow(part_htg_lat_eff) | ||
heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat100CoolingAirFlow(full_cool_sens_eff) | ||
heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat100CoolingAirFlow(full_cool_lat_eff) | ||
heat_exchanger_air_to_air_sensible_and_latent.setSensibleEffectivenessat75CoolingAirFlow(part_cool_sens_eff) | ||
heat_exchanger_air_to_air_sensible_and_latent.setLatentEffectivenessat75CoolingAirFlow(part_cool_lat_eff) | ||
|
||
OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.HeatExchangerSensLat', "For #{heat_exchanger_air_to_air_sensible_and_latent.name}: Set sensible and latent effectiveness calculated by using ERR.") | ||
return true | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge in the other commit for furnaces to this pull request