Initializes nrcan_446 branch: skylights & wells #1854

brgix · 2024-11-25T17:03:44Z

Pull request overview

Description

BTAP is currently limited in how/where it adds NECB-required skylights in OpenStudio models (e.g. SRR 5% for NECB2011). Outstanding limitations include sloped roofs, narrow/concave roof surfaces, plenum/attic cases (requiring skylight wells). These initial limitations are understandable, given the challenges of dealing with odd or finely-grained geometry - no walk in the park. Yet without a general solution, BTAP remains unable to quantify (to the full extent) energy/carbon savings (or more commonly penalties) from code-required skylights in NECB reference buildings.

Approach

The solution is part of the OSut gem, a TBD dependency (TBD is now a standard OpenStudio gem, and is distributed with BTAP/OpenStudio-Standards). OSut's addSkylights method tackles the above limitations. It can fail with invalid geometry (e.g. some of the DND models!), or if model geometry is, let's say, unreasonable (e.g. just a bunch of closets, or where all roof surfaces are heavily tessellated or subdivided as strips the width of a desk). This unfortunately may happen with 3rd-party models! Easiest to consult related OSut PRs, here & here.

Testing Plan

OSut's addSkylights is regularly tested in isolation: e.g. OSut RSpec, and recently stress-tested on ALL DND projects (private repo, some BTAP staff have access). Specific BTAP unit tests are nonetheless needed. Existing regression tests will need to be updated, as the implications of a general solution are somewhat far reaching (e.g. automatic photocell placement, heating/cooling sizing, resulting energy use + carbon emissions).

Related issues

This work may solve the concerns raised here & here - not sure.

Pull Request Author

Method changes or additions
Data changes or additions
Added tests for added methods
If methods have been deprecated, update rest of code to use the new methods
Documented new methods using yard syntax
Resolved yard documentation errors for new code (ran bundle exec rake doc)
Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
All new and existing tests passes
If the code adds new require statements, ensure these are in core ruby or add to the gemspec

Review Checklist

This will not be exhaustively relevant to every PR.

Perform a code review on GitHub
All related changes have been implemented: method additions, changes, tests
If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
If a new feature, test the new feature and try creative ways to break it
CI status: all green or justified

brgix · 2024-12-06T19:41:25Z

lib/openstudio-standards/btap/bridging.rb

@@ -1502,7 +1502,7 @@ def initialize(model = nil, argh = {})
          next unless construction[:stypes  ] == stypes
          next     if construction[:surfaces].empty?

-          construction[:surfaces].values.each { |surface| surface.setConstruction(construction[:uo]) }
+          # construction[:surfaces].values.each { |surface| surface.setConstruction(construction[:uo]) }


Not sure what this call is attempting, but commenting it out allows BTAP thermal bridging tests to pass. A revised skylight/well distribution would affect (linear) thermal bridging calculations down the line ...

brgix · 2024-12-10T10:12:49Z

openstudio-standards.gemspec

@@ -51,7 +51,7 @@ Gem::Specification.new do |spec|
  spec.add_development_dependency 'rubyXL', '~> 3.4'
  spec.add_development_dependency 'simplecov', '0.22.0'
  spec.add_development_dependency 'yard', '~> 0.9'
-  spec.add_runtime_dependency 'tbd'
+  spec.add_runtime_dependency 'tbd', '~> 3.4.4'


The autozone sizing runs rely on an older OpenStudio linking to a much older OSut gem:

osut (0.2.8) ':/ruby/2.7.0/gems/osut-0.2.8'

Updating the gemspec and Gemfile.lock files to set the minimum TBD & OSut gem versions. This is not fixing the observed issue, yet keeping it here as a reminder.

EDIT: mainly a local gem management issue - fixed. That said, OpenStudio & Standards would be better off with:

TBD 3.4.4

Out 0.6.0

See here- good!

brgix · 2024-12-10T10:22:16Z

lib/openstudio-standards/standards/necb/NECB2011/building_envelope.rb

+  #           It distinguishes between plenums and other conditioned spaces. It uses only the non-plenum roof area to
+  #           calculate the maximum skylight area to be applied to the building.
+  #
+  # OPTION B: Selected if srr_opt == 'osut'. OSut's 'addSkylights' attempts to meet the requested SRR% target, even if


Method apply_max_srr_nrcan now offers two options. By default, OSut's addSkylights is not called (srr_opt: is defaulted to an empty string). If instead set to 'osut', BTAP would rely on addSkylights to match the requested :srr_lim, either to match NECB fixed SRR% requirements, or some user-set SRR%.

brgix · 2024-12-10T10:40:05Z

lib/openstudio-standards/standards/necb/NECB2011/building_envelope.rb

+      # the requested skylight area, often by 10% to 15%. This makes it unfair
+      # for NECBs, and more challenging when dealing with skylight wells. This
+      # issue only applies with attics - not plenums. Trim down SRR if required.
+      target = (srr_lim * graX / gra0) * graX


OSut's addSkylights yields better results if smaller utility/technical rooms (e.g. narrow corridors, WCs) are first set aside. If feasible, addSkylights prioritizes larger spaces that aren't daylit.

Hospital prototype

For this reason, it is preferable to send as argument the actual SRR-based skylight area (addSkyLights(spaces, {area: target})), rather than the initial SRR (addSkyLights(spaces, {srr: 0.05)). In both example addSkylights calls here, spaces is a subset of model.getSpaces.

Gross roof area (GRA) calculations should exclude (unconditioned) attic roof overhangs, such as in the SmallOffice prototype model. The calculated skylight area target is adjusted if attic overhangs are detected. No overhangs (i.e. graX/gra0 equals unity)? No adjustment.

brgix · 2024-12-10T10:41:32Z

lib/openstudio-standards/standards/necb/NECB2011/building_envelope.rb

+      types = types.reject { |tp| tp.nameString.downcase.include?("shower"   ) }
+      types = types.reject { |tp| tp.nameString.downcase.include?("washroom" ) }
+      types = types.reject { |tp| tp.nameString.downcase.include?("corr"     ) }
+      types = types.reject { |tp| tp.nameString.downcase.include?("stair"    ) }


Spacetype string patterns that are currently proposed to filter out utility/technical rooms.

brgix · 2024-12-10T10:55:20Z

lib/openstudio-standards/standards/necb/NECB2011/building_envelope.rb

+      skm2 = skys.sum(&:grossArea)
+
+      unless skm2.round == target.round
+        msg = "Skylights m2: failed to meet #{target.round} (vs #{skm2.round})"


Challenging model geometry (e.g. invalid geometry, tiny rooms, heavily tessellated roof surfaces) is usually behind the rare cases where addSkylights fails to meet the requested target area. Skylights (and if required, skylight wells) may still be added - yet possibly insufficient in number to reach the target.

NorthernEducation BTAP prototype, meeting the requested building 5% SRR.

Same NorthernEducation BTAP prototype, yet without rendering plenum roof surfaces - only skylight well walls

brgix · 2024-12-10T10:56:48Z

test/necb/unit_tests/tests/test_necb_skylights.rb

+            srr = case template
+                  when 'NECB2020' then 0.02
+                  when 'NECB2017' then 0.02
+                  else                 0.05 # e.g. NECB2011, NECB2015


For now, only testing NECB2011 5% SRR (toughest target to meet).

brgix · 2024-12-10T11:02:10Z

test/necb/unit_tests/tests/test_necb_skylights.rb

+            # SRR% of 4.5%. The effective 'ratio' would vary based on geometry,
+            # e.g. larger building footprint, wider overhangs.
+            ratio = gra0.round > graX.round ? skm2 / graX : skm2 / gra0
+            assert(ratio.round(2) == srr, "BTAP/OSut: Incorrect SRR (#{cas})?")


Although the requested SRR-based target area is reduced when dealing with (unconditioned) attic roof overhangs (e.g. 4.5% instead of the requested 5%), it's always possible to validate whether a requested SRR of 5% is met by dividing skylight area by the effective gross roof area.

todo : ratio = gra0.round > graX.round ? skm2 / graX : skm2 / gra0 should of course boil down to ratio = skm2 / graX.

brgix · 2024-12-10T11:04:10Z

test/necb/unit_tests/tests/test_necb_skylights.rb

+              assert(log.key?(:level), "BTAP/OSut: log level (#{cas})?")
+              assert(log.key?(:message), "BTAP/OSut: log message (#{cas})?")
+              next if log[:level] < 1 # 'INFO'
+              next unless log.include?("(OSut::addSkylights)")


Internal OSut logs can be accessed, ideally by filtering for appended (OSut::addSkylights) in the log messages.

brgix · 2024-12-11T15:22:05Z

test/necb/unit_tests/tests/test_necb_skylights.rb

      # 'NorthernEducation',
-      # 'QuickServiceRestaurant',
+      'QuickServiceRestaurant',
      # 'SmallOffice'


Currently having an issue with reported skylight area when dealing with the SmallOffice (attic roof overhangs). This works when tested in isolation (i.e. outside of OpenStudio-Standards/BTAP), so likely an unintended bug somewhere - my bad.

EDIT: Yup - error fixed.

brgix · 2024-12-11T15:23:26Z

test/necb/unit_tests/tests/test_necb_skylights.rb

      # 'SmallOffice'
    ]

+    # NOTE: Skipping NorthernEducation for now:
+    #   - Standards.Model.rb:5432: warning: instance variable @space_type_map not initialized
+    #   - model works in isolation (e.g. SDK 3.6.1, 3.7.0, 3.8.0)


The NorthernEducation model works with addSkylights just fine in isolation. This is likely more of a BTAP prototype family thing. Setting aside for now.

brgix · 2024-12-11T15:24:30Z

test/necb/unit_tests/tests/test_necb_skylights.rb

+            model.getSubSurfaces.each do |sub|
+              next unless sub.subSurfaceType.downcase == "skylight"
+
+              skm2 += sub.grossArea


That's more reasonable - slaps forehead.

brgix · 2024-12-11T19:51:00Z

lib/openstudio-standards/standards/necb/NECB2011/building_envelope.rb

@@ -776,6 +776,7 @@ def apply_max_srr_nrcan(model:, srr_lim:, srr_opt: '')
        sub_surface_create_scaled_subsurfaces_from_surface(surface: roof, area_fraction: srr_lim, construction: skylight_construct_set)
      end
    else # OPTION B
+      TBD.clean!


OSut piggy-backs on top of TBD. It shares the same internal logger. Clean reset.

brgix · 2024-12-11T19:51:17Z

lib/openstudio-standards/standards/necb/NECB2011/building_envelope.rb

@@ -810,7 +811,7 @@ def apply_max_srr_nrcan(model:, srr_lim:, srr_opt: '')
      # the requested skylight area, often by 10% to 15%. This makes it unfair
      # for NECBs, and more challenging when dealing with skylight wells. This
      # issue only applies with attics - not plenums. Trim down SRR if required.
-      target = (srr_lim * graX / gra0) * graX
+      target = (srr_lim * graX / gra0) * gra0


Silly mistake.

todo: target = (srr_lim * graX / gra0) * gra0 should of course be simply target = srr_lim * graX.

brgix · 2024-12-11T19:52:00Z

lib/openstudio-standards/standards/necb/NECB2011/building_envelope.rb

@@ -827,6 +828,7 @@ def apply_max_srr_nrcan(model:, srr_lim:, srr_opt: '')
      spaces = spaces.select { |sp| types.include?(sp.spaceType.get) }

      TBD.addSkyLights(spaces, {area: target})
+      self.osut[:logs] = TBD.logs


Hold on to OSut logged messages, in case.

brgix · 2024-12-11T19:53:33Z

test/necb/unit_tests/tests/test_necb_skylights.rb

-    #   - Standards.Model.rb:5432: warning: instance variable @space_type_map not initialized
-    #   - model works in isolation (e.g. SDK 3.6.1, 3.7.0, 3.8.0)
+    #   Minitest::UnexpectedError: RuntimeError: validation of model failed.
+    #   ... /openstudio-standards/lib/openstudio-standards/standards/necb/NECB2011/necb_2011.rb:714:in `apply_loads'


Keep (invalid?) NorthernEducation model aside.

brgix · 2025-01-14T13:13:57Z

test/necb/unit_tests/tests/test_necb_skylights.rb


+            ratio = skm2 / graX


Reducing equation - simpler to communicate (see here). No change in results.

brgix · 2025-01-14T13:15:02Z

lib/openstudio-standards/standards/necb/NECB2011/building_envelope.rb

@@ -811,7 +811,7 @@ def apply_max_srr_nrcan(model:, srr_lim:, srr_opt: '')
      # the requested skylight area, often by 10% to 15%. This makes it unfair
      # for NECBs, and more challenging when dealing with skylight wells. This
      # issue only applies with attics - not plenums. Trim down SRR if required.
-      target = (srr_lim * graX / gra0) * gra0
+      target = srr_lim * graX


Reducing equation - oversight (see here). No change in results.

Including nrcan branch changes into nrcan_446

brgix · 2025-01-15T21:29:30Z

lib/openstudio-standards/btap/bridging.rb

@@ -1502,7 +1502,8 @@ def initialize(model = nil, argh = {})
          next unless construction[:stypes  ] == stypes
          next     if construction[:surfaces].empty?

-          # construction[:surfaces].values.each { |surface| surface.setConstruction(construction[:uo]) }
+         BTAP::Geometry::Surfaces.set_surfaces_construction_conductance(construction[:surfaces].values, construction[:uo])
+         # construction[:surfaces].values.each { |surface| surface.setConstruction(construction[:uo]) }


Reintroducing the BTAP::Geometry::Surfaces.set_surfaces_construction_conductance call. This had changed about a year ago with this commit. However, the change couldn't have worked given that construction[:uo] is simply a U-factor (in W/K.m2). Reverting to the original solution for now.

TBD doesn't need to have uprated, clear-field U-factors reset for constructions this way. At the time, keeping track (within the BTAP-generated OSM) of the uprated construction U-factors was deemed useful for documentation/costing purposes. This can be achieved otherwise within BTAP. Other changes are expected over the next weeks, given the upcoming structure/construction changes to BTAP. So this may change.

Note that this is unrelated to skylight wells, and the change should be introduced under a new (or another existing) pull request. TODO.

brgix · 2025-01-21T12:53:38Z

lib/openstudio-standards/btap/bridging.rb

-    @@data[MASS2][ :bad][:jamb        ] = { psi: 0.350 }
-    @@data[MASS2][ :bad][:sill        ] = { psi: 0.350 }
+    @@data[MASS2][ :bad][:fenestration] = { psi: 0.350 }
+    @@data[MASS2][ :bad][:door        ] = { psi: 0.000 }


The need to distinguish fenestrated vs opaque subsurfaces is described in this PR. Committed changes in related branch nrcan_372 have largely been merged here. The initial PR and branch nrcan_372 will likely be closed without merging.

Initializes nrcan_446 branch: skylights & wells

2a4ed9b

brgix added the In Progress label Nov 25, 2024

brgix requested a review from ckirney November 25, 2024 17:03

brgix self-assigned this Nov 25, 2024

Comments out (broken) 'setConstruction' call

9dd78b6

brgix commented Dec 6, 2024

View reviewed changes

brgix added 2 commits December 9, 2024 11:28

Initial implementation + unit test

4fad85d

BTAP pre-1980 tweaks + gem spec tweaks

64536f3

brgix commented Dec 10, 2024

View reviewed changes

Fixes skylight gross area tally

32cb6f1

brgix commented Dec 11, 2024

View reviewed changes

Fixes SmallOffice roof overhang area bug

cfc5d71

brgix commented Dec 11, 2024

View reviewed changes

Reduces gra0 vs graX equations

4f72316

brgix commented Jan 14, 2025

View reviewed changes

ckirney and others added 2 commits January 14, 2025 11:34

Merge pull request #1874 from NREL/nrcan

e60c1e1

Including nrcan branch changes into nrcan_446

Reintroduce uprated Uo assignment

68e3f30

brgix commented Jan 15, 2025

View reviewed changes

Cleanup + full unit TBD tests

6691d2c

brgix commented Jan 21, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initializes nrcan_446 branch: skylights & wells #1854

Initializes nrcan_446 branch: skylights & wells #1854

brgix commented Nov 25, 2024 •

edited

Loading

brgix Dec 6, 2024 •

edited

Loading

brgix Dec 10, 2024 •

edited

Loading

brgix Jan 14, 2025

brgix Dec 10, 2024

brgix Dec 10, 2024

brgix Dec 10, 2024

brgix Dec 10, 2024

brgix Dec 10, 2024

brgix Dec 10, 2024

brgix Jan 14, 2025

brgix Dec 10, 2024

brgix Dec 11, 2024 •

edited

Loading

brgix Dec 11, 2024

brgix Dec 11, 2024

brgix Dec 11, 2024

brgix Dec 11, 2024

brgix Jan 14, 2025

brgix Dec 11, 2024

brgix Dec 11, 2024

brgix Jan 14, 2025 •

edited

Loading

brgix Jan 14, 2025 •

edited

Loading

brgix Jan 15, 2025 •

edited

Loading

brgix Jan 21, 2025 •

edited

Loading

Initializes nrcan_446 branch: skylights & wells #1854

Are you sure you want to change the base?

Initializes nrcan_446 branch: skylights & wells #1854

Conversation

brgix commented Nov 25, 2024 • edited Loading

Pull request overview

Description

Approach

Testing Plan

Related issues

Pull Request Author

Review Checklist

brgix Dec 6, 2024 • edited Loading

Choose a reason for hiding this comment

brgix Dec 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brgix Dec 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brgix Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

brgix Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

brgix Jan 15, 2025 • edited Loading

Choose a reason for hiding this comment

brgix Jan 21, 2025 • edited Loading

Choose a reason for hiding this comment

brgix commented Nov 25, 2024 •

edited

Loading

brgix Dec 6, 2024 •

edited

Loading

brgix Dec 10, 2024 •

edited

Loading

brgix Dec 11, 2024 •

edited

Loading

brgix Jan 14, 2025 •

edited

Loading

brgix Jan 14, 2025 •

edited

Loading

brgix Jan 15, 2025 •

edited

Loading

brgix Jan 21, 2025 •

edited

Loading