-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gb/pad bug #54
Gb/pad bug #54
Conversation
be4baaf
to
f6b8f6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you using np.pad in your current runs? How much slower is it for training?
No i didnt end up using np.pad anywhere because with how many padding ops we have it's just too slow. Still a good option if the model had fewer padding ops or if you wanted to do a single large fwp for any reason. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
- Coverage 88.64% 88.52% -0.13%
==========================================
Files 27 27
Lines 3329 3337 +8
==========================================
+ Hits 2951 2954 +3
- Misses 378 383 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
No description provided.