Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gb/pad bug #54

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Gb/pad bug #54

merged 4 commits into from
Nov 15, 2024

Conversation

grantbuster
Copy link
Member

No description provided.

Copy link
Collaborator

@bnb32 bnb32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you using np.pad in your current runs? How much slower is it for training?

@grantbuster
Copy link
Member Author

Are you using np.pad in your current runs? How much slower is it for training?

No i didnt end up using np.pad anywhere because with how many padding ops we have it's just too slow. Still a good option if the model had fewer padding ops or if you wanted to do a single large fwp for any reason.

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.52%. Comparing base (c5b0cdb) to head (ff29b5f).

Files with missing lines Patch % Lines
phygnn/layers/custom_layers.py 54.54% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   88.64%   88.52%   -0.13%     
==========================================
  Files          27       27              
  Lines        3329     3337       +8     
==========================================
+ Hits         2951     2954       +3     
- Misses        378      383       +5     
Flag Coverage Δ
unittests 88.52% <66.66%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grantbuster grantbuster merged commit c7a06b6 into main Nov 15, 2024
10 checks passed
@grantbuster grantbuster deleted the gb/pad_bug branch November 15, 2024 21:26
github-actions bot pushed a commit that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants