Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show number of YoY histogram points when detailed=True #324

Merged
merged 6 commits into from
May 18, 2022

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Apr 26, 2022

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • [ ] New functions added to __init__.py
  • [ ] API.rst is up to date, along with other sphinx docs pages
  • [ ] Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

See #298. I think detailed=True is not used in the example notebooks anywhere; worth using that somewhere to (1) highlight that it exists, and (2) see it in action for ourselves?

RTD failure is addressed by #325

Copy link
Collaborator

@mdeceglie mdeceglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdeceglie mdeceglie merged commit 827361f into development May 18, 2022
@mdeceglie mdeceglie deleted the n_slopes branch May 18, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants