-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move json getter extensions to core crate #286
Move json getter extensions to core crate #286
Conversation
…nd config_json_extension.rs from routee-compass crate to routee-compass-core crate
…onfigJsonExtensions from routee-compass crate to routee-compass-core crate
…n is is routee-compass, moved compass_configuration_error to routee-core crate; also remove ConfigError as we don't have enum ConfigError
…from core, and PluginError from routee-compass crate
…tputPluginBuilder, ComponentComponentError has PluginError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks @iantei for taking care of this, we have had to use a lot of work-arounds to do similar JSON->Rust object build
methods elsewhere in the workspace. We should be able to start unraveling that and also standardize these extension methods as well, since there is some redundancy. 🍻
@iantei this PR has been approved. we usually leave clicking "Merge pull request" to the PR author. if you're not given that option, let me know, maybe our GitHub repo settings aren't correctly set. |
@robfitzgerald I thought the review was still pending from @nreinicke. Thank you for letting me know about the process. |
no problem! on this repo, we only require one approval from a write-authorized contributor to merge a PR, unless someone says otherwise (like if the PR is complex and could use a second review). |
This PR is the implementation for #88
routee-compass
crate toroutee-compass-core
crate:use
fromroutee-compass
toroutee-compass-core
for the aboveCompassConfigurationError
,CompassConfigurationField
andConfigJsonExtensions
CompassComponentError
which includesPluginError
- removed PluginError from CompassConfigurationError since we Plugins is specifically in routee-compass.CompassComponentError
, since it needs PluginError.