Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Azure Pipelines integration #21

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Conversation

mrakitin
Copy link
Member

@mrakitin mrakitin commented Sep 13, 2019

Uses https://github.com/NSLS-II/profile-collection-ci.

Currently fails on caproto client (https://dev.azure.com/nsls2/profile_collections/_build/results?buildId=63):

CaprotoTimeoutError‌: <PV name='XF:02ID1-ES{RIXSCam}:HDF1:PluginType_RBV' priority=0 (searching....)> could not connect within 1.0-second timeout.‌
Exception in thread retry:
Traceback (most recent call last):
  File "/home/vsts/mc/envs/collection-2019C3.0.1/lib/python3.6/threading.py", line 916, in _bootstrap_inner
    self.run()
  File "/home/vsts/mc/envs/collection-2019C3.0.1/lib/python3.6/threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "/home/vsts/mc/envs/collection-2019C3.0.1/lib/python3.6/site-packages/caproto/threading/client.py", line 858, in _retry_unanswered_searches
    SEARCH_MAX_DATAGRAM_BYTES - len(version_req)):
  File "/home/vsts/mc/envs/collection-2019C3.0.1/lib/python3.6/site-packages/caproto/_utils.py", line 772, in batch_requests
    for command in request_iter:
  File "/home/vsts/mc/envs/collection-2019C3.0.1/lib/python3.6/site-packages/caproto/threading/client.py", line 830, in _construct_search_requests
    ca.DEFAULT_PROTOCOL_VERSION)
  File "/home/vsts/mc/envs/collection-2019C3.0.1/lib/python3.6/site-packages/caproto/_commands.py", line 607, in __init__
    ''.format(MAX_RECORD_LENGTH, name, _len))
caproto._utils.CaprotoValueError: EPICS 3.14 imposes a 59-character limit on record names. The record 'XF:02ID1-ES{RIXSCam}:XIP1:HR_ISOLINEAR_CALIBRATION_THRESHOLD' is 60 characters.

xref NSLS-II/profile-collection-ci#2

@mrakitin
Copy link
Member Author

attn @danielballan, I encountered another issue with SIX's profile files.

@mrakitin
Copy link
Member Author

The problem should be resolved at the IOC level, reported via https://controlsweb.nsls2.bnl.gov/trac/ticket/3906#ticket.

@mrakitin mrakitin marked this pull request as ready for review September 13, 2019 19:40
@mrakitin
Copy link
Member Author

For now this PR has nothing to do with the IOC configuration, and can be merged to enable the CI integration.

@danielballan, do you mind to have a look?

@mrakitin mrakitin mentioned this pull request Sep 13, 2019
@mrakitin
Copy link
Member Author

The issue #22 will handle the too-long-PV. This PR is good to go.

@johnsinsheimer
Copy link

Interestingly, I can caget this PV, despite the excessive characters, but I'll see if there is anything I can do with the IOC

@mrakitin
Copy link
Member Author

Thank you, @johnsinsheimer! Epics CLI tools (caget, ...) and pyepics seem to be quite forgiving, so we haven't noticed the issue until now using caproto.

@mrakitin
Copy link
Member Author

I think it's good to go in "as is". The known issues are understood and documented, all other updated will be made via separate PRs.

@mrakitin
Copy link
Member Author

@ambarb, do you have any concerns regarding this update? It does not affect any code, just wanted to bring it to your attention.

Copy link
Contributor

@ambarb ambarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrakitin thanks for the information. I didn't do much with this part of the profile so @awalter-bnl would be the best

@mrakitin
Copy link
Member Author

This PR does not touch any startup files, self-merging.

@mrakitin mrakitin merged commit d173c50 into NSLS-II-SIX:master Sep 23, 2019
@mrakitin mrakitin deleted the azure branch September 23, 2019 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants