Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Llama2 7B recipe #11649

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Add Llama2 7B recipe #11649

merged 3 commits into from
Feb 7, 2025

Conversation

suiyoubi
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@suiyoubi suiyoubi force-pushed the aot/llama2-7b-recipe branch from 3134cd0 to 60662e5 Compare December 18, 2024 15:48
Copy link
Contributor

github-actions bot commented Jan 2, 2025

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

This PR was closed because it has been inactive for 7 days since being marked as stale.

@suiyoubi suiyoubi enabled auto-merge (squash) February 6, 2025 00:58
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.43%. Comparing base (fdfeafe) to head (78e33f2).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #11649    +/-   ##
========================================
  Coverage   30.42%   30.43%            
========================================
  Files        1400     1401     +1     
  Lines      177452   177568   +116     
  Branches    27196    27211    +15     
========================================
+ Hits        53990    54036    +46     
- Misses     119345   119408    +63     
- Partials     4117     4124     +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

[🤖]: Hi @suiyoubi 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@suiyoubi suiyoubi disabled auto-merge February 6, 2025 14:14
@suiyoubi suiyoubi removed the request for review from huvunvidia February 6, 2025 14:14
@suiyoubi suiyoubi added Run CICD and removed Run CICD labels Feb 6, 2025
@suiyoubi suiyoubi enabled auto-merge (squash) February 6, 2025 14:17
@suiyoubi suiyoubi added Run CICD and removed Run CICD labels Feb 7, 2025
@ko3n1g
Copy link
Collaborator

ko3n1g commented Feb 7, 2025

Manually force-merging since no unit/integration test covers this patch anyway

@ko3n1g ko3n1g disabled auto-merge February 7, 2025 17:17
@ko3n1g ko3n1g merged commit 1446c89 into main Feb 7, 2025
122 of 224 checks passed
@ko3n1g ko3n1g deleted the aot/llama2-7b-recipe branch February 7, 2025 17:17
BoxiangW pushed a commit that referenced this pull request Feb 7, 2025
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants