-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed asr models outputs to be consistent #11818
Conversation
scripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_transducer.py
Fixed
Show fixed
Hide fixed
ed59fd2
to
3ca6a8a
Compare
3ca6a8a
to
4232b64
Compare
Overall looks good! Thank you.
|
ee896e4
to
8549980
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only glanced at it but this PR is full of breaking changes. Upto @nithinraok if he's ok with it, I don't see the reason for most of these naming changes.
bd17125
to
3987d43
Compare
6f5c59c
to
b2013e6
Compare
5256383
to
4f60b78
Compare
Signed-off-by: Ssofja <[email protected]>
Signed-off-by: Ssofja <[email protected]> Signed-off-by: Ssofja <[email protected]>
Signed-off-by: Ssofja <[email protected]> Signed-off-by: Ssofja <[email protected]>
Signed-off-by: Ssofja <[email protected]>
Signed-off-by: Ssofja <[email protected]> Signed-off-by: Ssofja <[email protected]>
Signed-off-by: Ssofja <[email protected]>
Signed-off-by: Ssofja <[email protected]>
Signed-off-by: Ssofja <[email protected]> Signed-off-by: Ssofja <[email protected]>
Signed-off-by: Ssofja <[email protected]>
Signed-off-by: Ssofja <[email protected]>
Signed-off-by: Ssofja <[email protected]> Signed-off-by: Ssofja <[email protected]>
Signed-off-by: Ssofja <[email protected]> Signed-off-by: Ssofja <[email protected]>
4f60b78
to
a4176a2
Compare
a4176a2
to
cd6a13c
Compare
Signed-off-by: Ssofja <[email protected]> Signed-off-by: Ssofja <[email protected]>
cd6a13c
to
30b3ec1
Compare
[🤖]: Hi @Ssofja 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please remember to update:
- huggingface model cards and spaces using main
- Add to docs
What does this PR do ?
This PR is making all ASR models outputs to be consistent and always user can expect List[Hypothesis] by default.
Collection: ASR
Changelog
Usage
From command-line
with transcribe_speech.py script
From Python Env
The change is done for CTC, RNNT and AED models
Previous version
Where
best_hypotheses
isList[str]
,all_hypotheses
isList[List[str]]
And in the case when
return_hypotheses
isTrue
it returns a tuple ofList[Hypothesis]
andOptional(List[List[Hypothesis]])
New version
where
hypotheses
isList[Hypothesis]
or ifhypothesis
type isNBestHypotheses
, the function will returnList[List[Hypothesis]]
. Inhypotheses
here onlyy_sequence
,score
,text
variables are set, all other variables are default valuesIf
return_hypotheses
isTrue
all variables ofhypotheses
are setEach output contains hypothesis object and user can get text, timestamp and other arguments from Hypothesis data class:
It is important to remember, that in previous versions transcribe method had an argument timestep which was renamed to timestamp
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
PR Type: