-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pre-commit.ci] pre-commit autoupdate #1928
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. Even automatically formatting the code to the new version! I love it!
I would appreciate a second review since I don't know whether any further action is required here.
9df96fd
to
b2ba0a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever this auto-update happens, we also need to update the version of clang-format
in our devcontainers or else formatting within the devcontainer will be different from what pre-commit expects.
The version in our devcontainers is specified here: https://github.com/rapidsai/devcontainers/blob/95821d7b92b2e4f7c58395a418ddaa1b7944eb04/matrix.yml#L44
Is there a way we can use |
It's possible to run |
Ah, now I understand what you mean. It's about the clang-format version VSCode uses, right? That's a different issue. |
I believe there are two things in play. Everything that happens locally in the devcontainer uses clang-format 17.06 but the pre-commit-ci bot uses its own version which is different |
I asked the devcontainers to upgrade: rapidsai/devcontainers#341 |
PR to upgrade devcontainers: rapidsai/devcontainers#343 |
The remaining concern I have is the minor and patch version of clang-format we are going to specify for pre-commit now. For the devcontainers, I only specified clang-format 18, but neither minar nor patch version. Will they always use the latest of the specified major series? And is that the same across the various Ubuntu versions we use in the CI? |
203c722
to
404005a
Compare
The devcontainers install LLVM packages from the |
I just checked and the devcontainers fetched clang-format 18.1.8, which is exactly what pre-commit upgraded to in this PR :D |
updates: - [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0) - [github.com/pre-commit/mirrors-clang-format: v17.0.6 → v18.1.8](pre-commit/mirrors-clang-format@v17.0.6...v18.1.8)
404005a
to
a3d8f6d
Compare
@jrhemstad the new devcontainers are landing, please unblock this PR. |
/ok to test |
🟨 CI finished in 4h 04m: Pass: 99%/420 | Total: 7d 00h | Avg: 24m 08s | Max: 1h 08m | Hits: 23%/523029
|
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
🏃 Runner counts (total jobs: 420)
# | Runner |
---|---|
305 | linux-amd64-cpu16 |
64 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
23 | windows-amd64-cpu16 |
Pull Request is not mergeable
🟩 CI finished in 7h 19m: Pass: 100%/420 | Total: 7d 01h | Avg: 24m 13s | Max: 1h 08m | Hits: 23%/523029
|
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
🏃 Runner counts (total jobs: 420)
# | Runner |
---|---|
305 | linux-amd64-cpu16 |
64 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
23 | windows-amd64-cpu16 |
@jrhemstad please unblock. |
* [pre-commit.ci] pre-commit autoupdate updates: - [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0) - [github.com/pre-commit/mirrors-clang-format: v17.0.6 → v18.1.8](pre-commit/mirrors-clang-format@v17.0.6...v18.1.8) * [pre-commit.ci] auto code formatting --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates: