Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] Add erase for experimental::dynamic_map #577

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

[DRAFT] Add erase for experimental::dynamic_map #577

wants to merge 2 commits into from

Conversation

ZelboK
Copy link
Contributor

@ZelboK ZelboK commented Aug 12, 2024

This PR is not ready - I will mark it ready for review when it is. Please do not run the tests for now

This PR:

  1. Continues on the previous work for transitioning away from the legacy::static_map by adding erase
  2. Adds respective tests for such

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 12, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ZelboK ZelboK marked this pull request as draft August 12, 2024 19:32
@PointKernel PointKernel added topic: dynamic_map Issue related to the dynamic_map In Progress Currently a work in progress type: improvement Improvement / enhancement to an existing function labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleeepyjack sleeepyjack Awaiting requested review from sleeepyjack sleeepyjack is a code owner

@PointKernel PointKernel Awaiting requested review from PointKernel PointKernel is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
In Progress Currently a work in progress topic: dynamic_map Issue related to the dynamic_map type: improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZelboK @PointKernel