Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[photonics] [C++] Support 'get_state' API #2152

Merged
merged 5 commits into from
Sep 4, 2024
Merged

[photonics] [C++] Support 'get_state' API #2152

merged 5 commits into from
Sep 4, 2024

Conversation

khalatepradnya
Copy link
Collaborator

Towards: 'photonics' target support

@khalatepradnya
Copy link
Collaborator Author

@Omar-ORCA for visibility

@khalatepradnya khalatepradnya self-assigned this Aug 26, 2024
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 26, 2024
@cuda-quantum-bot
Docs preview for PR #2152.
a542a57
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 27, 2024
@cuda-quantum-bot
Docs preview for PR #2152.
c0c0151
@khalatepradnya khalatepradnya added the enhancement New feature or request label Aug 28, 2024
github-actions bot pushed a commit that referenced this pull request Aug 30, 2024
@cuda-quantum-bot
Docs preview for PR #2152.
08a668a
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@khalatepradnya khalatepradnya marked this pull request as ready for review September 2, 2024 04:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 2, 2024
@cuda-quantum-bot
Docs preview for PR #2152.
59d4715
@thorinf-orca
Copy link

Hi Pradnya,

This looks great, thanks for working on this for us. Do you have any guidance on how we could do our Python bindings?

Thanks,

Thorin

@khalatepradnya
Copy link
Collaborator Author

Hi Pradnya,

This looks great, thanks for working on this for us. Do you have any guidance on how we could do our Python bindings?

Thanks,

Thorin

Thanks, Thorin! You will need the changes in PR# #2055 to add Python bindings for get_state() API for the photonics target.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
@cuda-quantum-bot
Docs preview for PR #2152.
75e8e41
1tnguyen
1tnguyen approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@1tnguyen 1tnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khalatepradnya khalatepradnya enabled auto-merge (squash) September 4, 2024 21:46
@khalatepradnya khalatepradnya merged commit bdea842 into NVIDIA:main Sep 4, 2024
129 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
@khalatepradnya khalatepradnya deleted the cpp_photonics_get_state branch September 9, 2024 19:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@1tnguyen 1tnguyen 1tnguyen approved these changes

@bmhowe23 bmhowe23 Awaiting requested review from bmhowe23

@amccaskey amccaskey Awaiting requested review from amccaskey

@annagrin annagrin Awaiting requested review from annagrin

@anthony-santana anthony-santana Awaiting requested review from anthony-santana

Assignees

@khalatepradnya khalatepradnya

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khalatepradnya @thorinf-orca @1tnguyen