Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exp_pauli issues on remote simulators and quantum devices #2226

Merged
merged 12 commits into from
Sep 30, 2024
Merged

Fix exp_pauli issues on remote simulators and quantum devices #2226

merged 12 commits into from
Sep 30, 2024

Conversation

annagrin
Copy link
Collaborator

@annagrin annagrin commented Sep 24, 2024 •
edited
Loading

Description

Fix exp_pauli issues on remote simulators and quantum devices

  • Make DecompositionPatterns recognize code generated by argument synthesis for pauli word parameters
  • Fix an issue in quake-to-qir pass where the IR produced had incorrect type for a store destination.

Closes: #2222
Closes: #2227

1tnguyen
1tnguyen approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@1tnguyen 1tnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
@cuda-quantum-bot
Docs preview for PR #2226.
9dd42a8
@annagrin annagrin enabled auto-merge (squash) September 24, 2024 22:29
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 25, 2024
@cuda-quantum-bot
Docs preview for PR #2226.
57dfca1
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 25, 2024
@cuda-quantum-bot
Docs preview for PR #2226.
53fd439
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 25, 2024
@cuda-quantum-bot
Docs preview for PR #2226.
c90257f
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 26, 2024
@cuda-quantum-bot
Docs preview for PR #2226.
a6f6a6f
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 26, 2024
@cuda-quantum-bot
Docs preview for PR #2226.
5cb641b
github-actions bot pushed a commit that referenced this pull request Sep 26, 2024
@cuda-quantum-bot
Docs preview for PR #2226.
f6e15e7
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

schweitzpgi
schweitzpgi approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/Optimizer/Transforms/DecompositionPatterns.cpp Outdated Show resolved Hide resolved
@annagrin annagrin mentioned this pull request Sep 30, 2024
Open
1 task
@annagrin annagrin merged commit e23ca18 into NVIDIA:main Sep 30, 2024
129 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@khalatepradnya khalatepradnya khalatepradnya left review comments

@1tnguyen 1tnguyen 1tnguyen approved these changes

@schweitzpgi schweitzpgi schweitzpgi approved these changes

@sacpis sacpis Awaiting requested review from sacpis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exp_pauli fails on remote simulator Support cudaq::exp_pauli for quantum devices
4 participants
@annagrin @schweitzpgi @1tnguyen @khalatepradnya