Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the cuTensor version and fix state retrieval logic for tensornet #2353

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Update the cuTensor version and fix state retrieval logic for tensornet #2353

merged 2 commits into from
Nov 5, 2024

Conversation

khalatepradnya
Copy link
Collaborator

@khalatepradnya khalatepradnya commented Nov 4, 2024 •
edited
Loading

Tested in local dev environment.

100% tests passed, 0 tests failed out of 709

Label Time Summary:
gpu_required    = 348.95 sec*proc (374 tests)

@khalatepradnya
* Update the cuTensor version
c3eb283 
Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya
* Fix for qudit / qubit check in state retrieval
ce5cc3a 
Co-authored-by: Thien Nguyen <[email protected]>

Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya khalatepradnya changed the title Update the cuTensor version and fix get_state for tensornet Update the cuTensor version and fix state retrieval logic for tensornet Nov 4, 2024
@khalatepradnya khalatepradnya enabled auto-merge (squash) November 4, 2024 23:44
@1tnguyen
Copy link
Collaborator

1tnguyen commented Nov 4, 2024

This is related to #2333, in which we bumped the cuquantum version.
cutensornet v2.5 (in cuquantum 24.08) requires cuTENSOR v2.0.2 or above.

1tnguyen
1tnguyen approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@1tnguyen 1tnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks, @khalatepradnya !

@khalatepradnya khalatepradnya merged commit 03bd77c into NVIDIA:main Nov 5, 2024
207 checks passed
@khalatepradnya khalatepradnya deleted the fix-cutensor-version branch November 5, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1tnguyen 1tnguyen 1tnguyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khalatepradnya @1tnguyen