Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python metapackages #2356

Merged
merged 26 commits into from
Nov 7, 2024
Merged

Python metapackages #2356

merged 26 commits into from
Nov 7, 2024

Conversation

bettinaheim
Copy link
Collaborator

No description provided.

@bettinaheim bettinaheim changed the title Python metapackage Python metapackages Nov 5, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@90754d9). Learn more about missing BASE report.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2356   +/-   ##
=======================================
  Coverage        ?   78.66%           
=======================================
  Files           ?      338           
  Lines           ?    45693           
  Branches        ?        0           
=======================================
  Hits            ?    35943           
  Misses          ?     9750           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bettinaheim bettinaheim marked this pull request as ready for review November 6, 2024 14:29
@bettinaheim
renaming folder
6a4a8a6 
Signed-off-by: Bettina Heim <[email protected]>
sacpis
sacpis reviewed Nov 6, 2024
View reviewed changes
python/sdist/pyproject.toml Outdated Show resolved Hide resolved
sacpis
sacpis approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@sacpis sacpis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have few questions, but overall this PR looks good to me. Thanks @bettinaheim.

1tnguyen
1tnguyen approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@1tnguyen 1tnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bettinaheim bettinaheim enabled auto-merge (squash) November 7, 2024 18:54
@bettinaheim bettinaheim merged commit 7b42224 into main Nov 7, 2024
208 of 214 checks passed
@bettinaheim bettinaheim deleted the publishing branch November 7, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sacpis sacpis sacpis approved these changes

@1tnguyen 1tnguyen 1tnguyen approved these changes

@bmhowe23 bmhowe23 Awaiting requested review from bmhowe23 bmhowe23 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bettinaheim @sacpis @1tnguyen