Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to define publishing assets as repo variable, disable codeql for C++, and fix issue in nightly workflows #2375

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Allow to define publishing assets as repo variable, disable codeql for C++, and fix issue in nightly workflows #2375

merged 3 commits into from
Nov 13, 2024

Conversation

bettinaheim
Copy link
Collaborator

This will allow to configure the repo such that all publishing runs bypass rebuilding these assets.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 13, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@bettinaheim
Copy link
Collaborator Author

bettinaheim commented Nov 13, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@bettinaheim bettinaheim changed the title Adding the option to define manually created publishing assets as repo variable Allow to define publishing assets as repo variable, disable codeql for C++, and fix nightly tests Nov 13, 2024
@bettinaheim bettinaheim changed the title Allow to define publishing assets as repo variable, disable codeql for C++, and fix nightly tests Allow to define publishing assets as repo variable, disable codeql for C++, and fix issue in nightly workflows Nov 13, 2024
@bettinaheim
Copy link
Collaborator Author

bettinaheim commented Nov 13, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

sacpis
sacpis approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@sacpis sacpis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @bettinaheim.

schweitzpgi
schweitzpgi approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@bettinaheim bettinaheim merged commit 1b5baf8 into NVIDIA:main Nov 13, 2024
181 of 188 checks passed
@bettinaheim bettinaheim deleted the workflow_fixes branch November 13, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schweitzpgi schweitzpgi schweitzpgi approved these changes

@sacpis sacpis sacpis approved these changes

@1tnguyen 1tnguyen Awaiting requested review from 1tnguyen 1tnguyen is a code owner

@bmhowe23 bmhowe23 Awaiting requested review from bmhowe23 bmhowe23 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bettinaheim @sacpis @schweitzpgi