E2E tests can be run with default-counters.csv #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vadym Fedorov <[email protected]>
nvvfedorov
commented
Mar 20, 2024
nvvfedorov
commented
Mar 20, 2024
nvvfedorov
commented
Mar 20, 2024
nvvfedorov
commented
Mar 20, 2024
nvvfedorov
commented
Mar 20, 2024
nvvfedorov
commented
Mar 20, 2024
nvvfedorov
commented
Mar 20, 2024
nvvfedorov
force-pushed
the
e2e-work-without-profiling
branch
from
45147ef to
a8ef8ac
Compare
Signed-off-by: Vadym Fedorov <[email protected]>
rohit-arora-dev
previously approved these changes
Mar 21, 2024
Removed accidental change
rohit-arora-dev
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The E2E tests with default configuration use the helm release, which deploys the dcgm-exporter with the
dcp-metrics-included.csvconfiguration. This configuration includes profiling metrics available on the datacenter-grade GPU.For example, if you use
NVIDIA T400, the e2e test fails because the dcgm-exporter can not be initiated because of unsupported hardware.To provide the ability to run e2e tests on low-grade GPUs compatible with DCGM, I added the ability to specify custom arguments in the e2e scripts. As a result:
make e2ecommand runs e2e tests with enabled profiling metrics.