Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture an assert failure from cuvs cagra and rephrase error message to include relevant params #771

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

lijinf2
Copy link
Collaborator

@lijinf2 lijinf2 commented Oct 30, 2024

Error message: "k must be less than topk::kMaxCapacity (256)"
Captured with rephrased to f"cagra with ivf_pq build_algo expects intermediate_graph_degree ({intermediate_graph_degree}) to be smaller than 256"

Also added test cases of various type (float64, int16, int32).

@lijinf2
Copy link
Collaborator Author

lijinf2 commented Oct 30, 2024

build

Copy link
Collaborator

@eordentlich eordentlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lijinf2 lijinf2 merged commit 148d8ec into NVIDIA:branch-24.10 Nov 5, 2024
2 checks passed
@lijinf2 lijinf2 deleted the cagra_feature_type branch November 5, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants