Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triage and Fix csv_test.py and join_test.py failures #11650

Draft
wants to merge 9 commits into
base: branch-24.12
Choose a base branch
from

Conversation

rwlee
Copy link
Collaborator

@rwlee rwlee commented Oct 23, 2024

Resolves #11022
Resolves #11016

Fixes test failures caused by some overflow issues caused by the test, but not the focus or point of the test. Also marks and skips tests for Spark4 that fail due to ANSI mode aggregates, unsupported EmptyRelationExec, some renamed exceptions that are now SparkUpgradeExceptions.

Opened as draft in order to handoff, remaining needs are all related to csv_test.py::test_csv_fallback:

  • We should change the CSV test so that we use ansi_disabled_conf , because all we're testing is whether the CPU fallback is valid. Note: We specifically don't use @disable_ansi_mode in this case, because it is pre-triaged.
  • We add a function comment, indicating why we're disabling ANSI for this test. This includes a pointer to where we're testing ANSI overflow failures. (i.e. arithmetic_ops_test.py::test_addition).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix tests failures in join_test.py Fix tests failures in csv_test.py
1 participant