Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge C2C code to main #11720

Draft
wants to merge 3 commits into
base: branch-24.12
Choose a base branch
from
Draft

Merge C2C code to main #11720

wants to merge 3 commits into from

Conversation

res-life
Copy link
Collaborator

@res-life res-life commented Nov 13, 2024 •
edited
Loading

Merge C2C code to main

Move code from internal gitlab nvspark/spark-rapids

Signed-off-by: Chong Gao [email protected]

Merge C2C code to main
58b7f48 
Signed-off-by: Chong Gao <[email protected]>
@res-life
Copy link
Collaborator Author

res-life commented Nov 13, 2024 •
edited
Loading

It's draft, may missed some code change, will double check later.
This can not pass building, because Gluten backends-velox 1.2.0 jar is not deployed to public maven repo by Gluten community.
The building will pass if the Gluten jars are installed locally by maven install

jlowe
jlowe reviewed Nov 14, 2024
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please elaborate in the headline and description what this PR is doing. C2C is not a well-known acronym in the project and is not very descriptive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe left review comments

@sperlingxx sperlingxx Awaiting requested review from sperlingxx

@revans2 revans2 Awaiting requested review from revans2 revans2 will be requested when the pull request is marked ready for review revans2 is a code owner

@tgravescs tgravescs Awaiting requested review from tgravescs tgravescs will be requested when the pull request is marked ready for review tgravescs is a code owner

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 will be requested when the pull request is marked ready for review GaryShen2008 is a code owner

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu NvTimLiu will be requested when the pull request is marked ready for review NvTimLiu is a code owner

@gerashegalov gerashegalov Awaiting requested review from gerashegalov gerashegalov will be requested when the pull request is marked ready for review gerashegalov is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@res-life @jlowe