-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Enable event log for qualification & profiling tools testing … #12103
Conversation
…from IT on Databricks (NVIDIA#4217)" This reverts commit b18492e.
Signed-off-by: Gera Shegalov <[email protected]>
build |
Please add a description as to why this is being reverted. I get that it caused some hang, but why did it cause it. Then is there a followup issue to turn it back on because i assume it was turned on for a reason. |
The issue linked as being fixed #12096 provides the description of how the hang is triggered by the PR being reverted #4217 was turning on event logging which was already on by default. #4217 overrode xdist-aware setting of event log locations, and causes the hang I'll repeat this in the PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great catch, @gerashegalov. LGTM, FWIW.
thanks, I missed the description of solution/root cause in #12096 since it was under the steps to reproduce. I generally try to separate that out into a next comment but we don't have a convention for that. I just missed it. @zhanga5 to see why original pr went in if eventlogging already enabled? Maybe configuration missing |
This reverts #4217 commit b18492e.
#4217 was turning on event logging which was already on by default. #4217 overrode xdist-aware setting of event log locations, and causes the hang
Fixes #12096
Downstream steps in pipelines need to collect event logs under all eventlog_gw[0-9] paths