fix quaternion's gradients in PoseInverse, and a few other warp kernels #393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current conversions from wp.quaternion to wp.vec4 would stop gradients from properly propagating. This has caused the issue mentioned in curobo.geom.transform.pose_inverse or Pose.inverse() has incorrect gradients for quaternion #392.
Instead of
, this commit does the conversion from quaterniom to vec4 as
which seems to produce correct results in the example used in curobo.geom.transform.pose_inverse or Pose.inverse() has incorrect gradients for quaternion #392 .
A few other
wp.kernel
's in the same file were using the same conversion method, so are all modified accordingly.Fixed missing/extra
None
's in a fewbackward
functions, mentioned in Incorrect number of gradients in backward functions in curobo/src/curobo/geom/transform.py #382 .Please feel free to let me know if there are any issues.