Translation fix #297
Merged
Translation fix #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the classic NestAnalysis code. Its job is to determine how the translation vector (or stride vector) between dataspace point-sets changes between consecutive loop iterations. Note that if the translation vector is the "first-order derivative" of point sets, then this computation is effectively the second-order derivative. If this translation vector _changes_, then this code avoids computing the delta between consecutive point-sets and instead discards the old point set and installs the new one. This is done to emulate the behavior of simplistic hardware pattern generators that are unable to describe hierarchical patterns. However, this code needs a number of special cases, particularly stationarity detection (translation == 0). This is because we do want to allow patterns such as translation=<N,0,0,0,N,0,0,0,...>. However, this specific case was being detected as a translation vector change, resulting in the old point-set being thrown away and increasing the number of accesses to the next storage level. The entire logic has been re-written to carefully handle all cases.
OperationSpace::SaveAndSubtractIfSameStride().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major fix for detecting stride changes in classic NestAnalysis code. Check commit log for 002f916 for full details.