Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to storybook v7 #58

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Upgrade to storybook v7 #58

merged 1 commit into from
Aug 6, 2024

Conversation

jessicashanshanhuang
Copy link

Upgrading our current storybook version to the latest version 7, refer to this issue for context.

Copy link

netlify bot commented Jul 18, 2024

Deploy Preview for meek-klepon-586e39 ready!

Name Link
🔨 Latest commit 21bb069
🔍 Latest deploy log https://app.netlify.com/sites/meek-klepon-586e39/deploys/66b2485712b7d800088c7a68
😎 Deploy Preview https://deploy-preview-58--meek-klepon-586e39.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jessicashanshanhuang jessicashanshanhuang marked this pull request as ready for review July 18, 2024 22:14
@jessicashanshanhuang jessicashanshanhuang changed the title Upgrade storybook v7 Upgrade to storybook v7 Jul 18, 2024
@jessicashanshanhuang jessicashanshanhuang marked this pull request as draft July 19, 2024 15:17
@jessicashanshanhuang jessicashanshanhuang marked this pull request as ready for review July 19, 2024 15:22
@damonmcc damonmcc force-pushed the upgrade-storybook-v7 branch from c9abf14 to 8c3d034 Compare July 29, 2024 17:24
@damonmcc
Copy link
Member

@TylerMatteo made changes to not pin exact package versions and to drop the addition of the design add-on

@damonmcc damonmcc requested review from damonmcc and removed request for damonmcc July 29, 2024 17:56
@damonmcc damonmcc force-pushed the upgrade-storybook-v7 branch from 8c3d034 to 7acf1df Compare July 30, 2024 19:46
@damonmcc
Copy link
Member

damonmcc commented Aug 5, 2024

noting that I've been trying to resolve a concern: seeing storybook 8 in the lock file diff for peer dependencies

running npm install from main (no changes to package.json) fails with

While resolving: @nycplanning/streetscape@0.10.1
Found: storybook@7.6.20
node_modules/storybook
  dev storybook@"^7.4.1" from the root project

Could not resolve dependency:
peer storybook@"^8.2.7" from @storybook/components@8.2.7
node_modules/@storybook/components
  peer @storybook/components@">=7.0.12" from @chakra-ui/storybook-addon@5.1.0
  node_modules/@chakra-ui/storybook-addon
    dev @chakra-ui/storybook-addon@"^5.0.1" from the root project

Fix the upstream dependency conflict, or retry
this command with --force or --legacy-peer-deps
to accept an incorrect (and potentially broken) dependency resolution.

and npm install --legacy-peer-deps doesn't fail, but generates 5 instances of:

"peerDependencies": {
  "storybook": "^8.2.7"
}

@damonmcc damonmcc marked this pull request as draft August 5, 2024 21:27
@damonmcc damonmcc force-pushed the upgrade-storybook-v7 branch from bca6048 to a461327 Compare August 6, 2024 15:50
via `npx storybook@7 upgrade` and `npm dedupe`
@damonmcc damonmcc force-pushed the upgrade-storybook-v7 branch from a461327 to 21bb069 Compare August 6, 2024 15:59
@damonmcc damonmcc marked this pull request as ready for review August 6, 2024 16:01
@damonmcc damonmcc requested a review from TylerMatteo August 6, 2024 16:01
@damonmcc damonmcc merged commit 83420a9 into main Aug 6, 2024
5 checks passed
@damonmcc damonmcc deleted the upgrade-storybook-v7 branch August 6, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants