Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

369 Sort Capital Commitments by Managing Code Capital Project Id by Date #372

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

horatiorosa
Copy link
Contributor

Description

  • updated OpenAPI properties for CCMCCP id to include order variable
  • updated findCapitalCommitmentsByManagingCodeCapitalProjectId to sort the capital commitments by plannedDate
  • updated CCMCCP service spec to test results.order (results=Capital Commitments) value is plannedDate

TIckets

Closes #369

@horatiorosa horatiorosa self-assigned this Sep 4, 2024
@horatiorosa horatiorosa requested a review from a team September 4, 2024 19:20
TangoYankee
TangoYankee previously approved these changes Sep 4, 2024
 - updated OpenAPI properties for CCMCCP id to include order variable
 - updated `findCapitalCommitmentsByManagingCodeCapitalProjectId` to sort the capital commitments by `plannedDate`
 - updated CCMCCP service spec to test `results.order` (results=Capital Commitments) value is `plannedDate`
Copy link
Contributor

@pratishta pratishta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@horatiorosa horatiorosa merged commit 98fccd4 into main Sep 5, 2024
3 checks passed
@horatiorosa horatiorosa deleted the issue-369-sort-commitments branch September 5, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort commitments
3 participants