Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 Add new capital projects endpoint #410

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

dhochbaum-dcp
Copy link
Contributor

Endpoint should be /capital-projects.

  • Endpoint should have the following filters as query parameters:

    • limit (1-100, default 20)
    • offset (>=0, default 0)
  • Endpoint should be reflected in OpenAPI spec (regenerate files as needed)

  • Add tests for new endpoint

Completes #404

@TangoYankee
Copy link
Member

In addition to the service test, we should also have end to end tests

closes #404

Co-authored-by: tangoyankee <[email protected]>
@TangoYankee TangoYankee force-pushed the 404/add-new-capital-projects-endpoint branch from e038daf to eb1429c Compare January 31, 2025 16:33
Copy link
Contributor

@horatiorosa horatiorosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good y'all.

🚀

@TangoYankee TangoYankee merged commit 9bd287e into main Jan 31, 2025
3 checks passed
@TangoYankee TangoYankee deleted the 404/add-new-capital-projects-endpoint branch January 31, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants