Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sign up banner in staging #1143

Merged
merged 11 commits into from
Feb 14, 2024
Merged

Remove sign up banner in staging #1143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
85df294
Epic/13898 pff (#1097)
TangoYankee Sep 11, 2023
13c18b5
Bugs/epic 13898 (#1099)
TangoYankee Sep 25, 2023
49fe409
Epic/13898 pff (#1097) (#1098) (#1101)
TangoYankee Sep 25, 2023
3d9c95d
remove banner text for archive note
TangoYankee Sep 26, 2023
ab733f5
Add banner with link to sign up for user interviews
TylerMatteo Dec 12, 2023
2d4acca
Remove margin from info banner
TylerMatteo Dec 12, 2023
26ed2ad
Remove sign up banner (#1115)
TylerMatteo Jan 12, 2024
1a33ae9
issue/16067 updated initial pop-up greeting with new copy
horatiorosa Feb 6, 2024
0fca2ff
Merge branch 'staging' into develop
TylerMatteo Feb 14, 2024
a72de18
Add missing comma to netlify.toml
TylerMatteo Feb 14, 2024
6b3c964
Remove signup banner (#1142)
TylerMatteo Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/templates/application.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
<div class="info-banner"><p>In an effort to better serve the needs of users like you, we'd like to hear from you about how we can improve services like this site.&nbsp;</p><a href="https://cdn.forms-content.sg-form.com/baf12d06-9871-11ee-a52c-aee1d8d80675" target="_blank">Click here to sign up.</a></div>
<LabsUi::SiteHeader @responsiveNav={{true}} @responsiveSize="large" as |banner|>
<banner.title>
{{#link-to 'index'}}Population FactFinder{{/link-to}}
Expand Down
18 changes: 11 additions & 7 deletions app/templates/components/default-modal.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
<RevealModal @open={{this.openModal}} @closeModal={{this.toggleModal}}>
<h1 class="header-large">
NYC Population FactFinder has been updated with data from the newly released 2020 Census Demographic & Housing Characteristics (DHC) file.
<h1 class='header-large'>
NYC Population FactFinder will soon be updated with 2018-2022 American
Community Survey (ACS) data and with Detailed Race/Ethnicity Responses from
the 2020 Census.
</h1>

<h1 class="header-large mobile-header">
NYC Population FactFinder is optimized for desktop screen widths.
<h1 class='header-large mobile-header'>
NYC Population FactFinder is optimized for desktop screen widths.
</h1>

<p class="lead mobile-body">
Mobile support for NYC Population FactFinder will be added in the future. For the best experience, please use a browser with a minimum width of 1280px.
<p class='lead mobile-body'>
Mobile support for NYC Population FactFinder will be added in the future.
For the best experience, please use a browser with a minimum width of
1280px.
</p>
</RevealModal>
</RevealModal>
4 changes: 2 additions & 2 deletions config/environment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,8 @@ if (environment === 'local-api') {
}

if (environment === 'production') {
ENV['mapbox-gl'].map.style = 'https://labs-layers-api.herokuapp.com/v1/base/style.json';
ENV['ember-mapbox-composer'].host = 'https://labs-layers-api.herokuapp.com';
ENV['mapbox-gl'].map.style = 'https://layers-api.planninglabs.nyc/v1/base/style.json';
ENV['ember-mapbox-composer'].host = 'https://layers-api.planninglabs.nyc';
ENV.SupportServiceHost = process.env.API_URL || 'https://factfinder-api.herokuapp.com';
}

Expand Down
2 changes: 1 addition & 1 deletion netlify.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ command = "yarn build --environment=staging"

[context.carto-staging]
command = "yarn build --environment=carto-staging"
environment = { CARTO_USERNAME = "dcpadmin" API_URL = "https://factfinder-api-carto-staging.herokuapp.com" }
environment = { CARTO_USERNAME = "dcpadmin", API_URL = "https://factfinder-api-carto-staging.herokuapp.com" }

[context.deploy-preview]
environment = { API_URL = "https://factfinder-api-staging.herokuapp.com" }
Expand Down
Loading