issue 1650 add advisory message bar for staging environment #1665
Conversation
❌ Deploy Preview for labs-zap failed.
|
horatiorosa
force-pushed
the
issue/1650-advisory-banner-for-staging-environment
branch
6 times, most recently
from
23f9d0a to
53ccc93
Compare
| @@ -11,7 +11,6 @@ export default class ApplicationAdapter extends JSONAPIAdapter { | |||
| session; | |||
|
|
|||
| get headers() { | |||
| console.log(this.session); | |||
There was a problem hiding this comment.
Yeah, it seemed unnecessary to have the session printing to the console. I was thinking this was probably left after some some debugging.
| showSandboxWarningOn = ENV.featureFlagShowSandboxWarning; | ||
|
|
||
| // @argument | ||
| message = false; |
There was a problem hiding this comment.
Maybe make this an empty string if you need a default value? That way you aren't mixing bools and strings on the same property.
| @@ -0,0 +1,5 @@ | |||
| <div class="advisory-message"> | |||
There was a problem hiding this comment.
Maybe check if this.message is truthy and conditionally render the div based on that? That way we never accidentally render an empty bar.
There was a problem hiding this comment.
I don't think we would accidentally render an empty div as there is a check in the application template looking for the truthy value of the feature flag.
Were you thinking of something like:
{{#if this.message}}
<div class="advisory-message">
// ... code
- add advisory message component and template - added advisory message bar to application template - updated client environment with getFeatureFlagShowSandboxWarning function setting FEATURE_FLAG_SHOW_SANDBOX_WARNING env var - added application controller to access env vars in application template
horatiorosa
force-pushed
the
issue/1650-advisory-banner-for-staging-environment
branch
from
53ccc93 to
e229823
Compare
Summary
Advisory message bar for staging environment
getFeatureFlagShowSandboxWarningfunction settingFEATURE_FLAG_SHOW_SANDBOX_WARNINGenv varTasks/Bug Numbers