Allow Multiple Measurements #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for labs-zola failed.
|
dhochbaum-dcp
changed the title
TylerMatteo
requested changes
May 8, 2024
| @@ -56,11 +138,12 @@ export default class MapMeasurementToolsComponent extends Component { | |||
| const drawMode = type === 'line' ? 'draw_line_string' : 'draw_polygon'; | |||
| const { mainMap } = this; | |||
| if (mainMap.get('drawMode')) { | |||
| draw.deleteAll(); | |||
| // the following have been commented out, as we no longer want to clear all previous drawings unless the user hits the x button | |||
There was a problem hiding this comment.
No need to commit commented out code. If we don't need it, delete it. If we have to bring it back, that's what git is for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, clicking the distance or area button clears any previously drawn distance/area. With this PR, you are now able to draw multiple lines or shapes, and able to see the sum of the drawn distances/areas. The X button continues to clear all drawn shapes and stored measurements.
Completes #1195