Pop Up Modal #1197
Merged
Pop Up Modal #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for labs-zola ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…istrict Info improvement is missing from both.
TylerMatteo
requested changes
May 21, 2024
app/controllers/application.js
Outdated
|
|
||
| @action toggleModal() { | ||
| this.openModal = !this.openModal; | ||
| // Uncomment this when done so that the message only shows the first time |
There was a problem hiding this comment.
Can we remove these 3 commented lines now? I'd rather they not land in develop
There was a problem hiding this comment.
I've removed them, although I don't really understand why. They make it easy for any developer in the future to switch between showing the modal once, showing the modal until the user hits the checkbox, or always showing the modal. What's the drawback?
TylerMatteo
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a pop-up modal to the site to display on page load. It has:
window.localStorage.clear()in the developer console and refresh to be able to see it againCompletes #1196