Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

City of Yes for Housing Opportunity #1216

Merged
merged 1 commit into from
Jan 2, 2025
Merged

City of Yes for Housing Opportunity #1216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/layer-record-views/tax-lot/intersecting-layers-views.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ export default class IntersectingLayersViews extends Component {

tables = [
'inclusionary_housing',
'transitzones',
'fresh_zones',
'waterfront_access_plan',
'coastal_zone_boundary',
Expand All @@ -15,6 +14,7 @@ export default class IntersectingLayersViews extends Component {
'mandatory_inclusionary_housing',
'e_designations',
'upland_waterfront_areas',
'transitzones',
'appendixj_designated_mdistricts',
];
}
18 changes: 15 additions & 3 deletions app/templates/components/layer-palette.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,17 @@
@layerGroup={{this.layerGroups.inclusionary-housing}}
@activeTooltip={{zoom-dependent-label this.layerGroups.inclusionary-housing this.zoomWarningLabel this.mainMap.zoom}}/>
<container.layer-group-toggle
data-test-toggle-transit-zones
@layerGroup={{this.layerGroups.transit-zones}}
@activeTooltip={{zoom-dependent-label this.layerGroups.transit-zones this.zoomWarningLabel this.mainMap.zoom}}/>
data-test-toggle-cho-greater-transit-zone
@layerGroup={{this.layerGroups.cho-greater-transit-zone}}
@activeTooltip={{zoom-dependent-label this.layerGroups.cho-greater-transit-zone this.zoomWarningLabel this.mainMap.zoom}}>
<LabsUi::LegendItems @items={{this.layerGroups.cho-greater-transit-zone.legend.items}} />
</container.layer-group-toggle>
<container.layer-group-toggle
data-test-toggle-cho-transit-zones
@layerGroup={{this.layerGroups.cho-transit-zones}}
@activeTooltip={{zoom-dependent-label this.layerGroups.cho-transit-zones this.zoomWarningLabel this.mainMap.zoom}}>
<LabsUi::LegendItems @items={{this.layerGroups.cho-transit-zones.legend.items}} />
</container.layer-group-toggle>
<container.layer-group-toggle
data-test-toggle-fresh
@layerGroup={{this.layerGroups.fresh}}
Expand Down Expand Up @@ -214,6 +222,10 @@
@activeTooltip={{zoom-dependent-label this.layerGroups.e-designations this.zoomWarningLabel this.mainMap.zoom}}>
<LabsUi::LegendItem @item={{this.layerGroups.e-designations.legend}} />
</container.layer-group-toggle>
<container.layer-group-toggle
data-test-toggle-transit-zones
@layerGroup={{this.layerGroups.transit-zones}}
@activeTooltip={{zoom-dependent-label this.layerGroups.transit-zones this.zoomWarningLabel this.mainMap.zoom}}/>
<container.layer-group-toggle
data-test-toggle-appendixj-designated-mdistricts
@layerGroup={{this.layerGroups.appendixj-designated-mdistricts}}
Expand Down
22 changes: 11 additions & 11 deletions app/templates/components/layer-record-views/tax-lot/intersecting-layers-views.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,6 @@
</a>
</li>
{{/if}}
{{#if layers.transitzones}}
<li>
<a
target="_blank"
href="http://www1.nyc.gov/site/planning/zoning/glossary.page#transit_zone" rel="noopener noreferrer"
>
<FaIcon @icon="external-link-alt" @transform="shrink-3 up-1" />
Transit Zone
</a>
</li>
{{/if}}
{{#if layers.fresh_zones}}
<li>
<a
Expand Down Expand Up @@ -144,6 +133,17 @@
</a>
</li>
{{/if}}
{{#if layers.transitzones}}
<li>
<a
target="_blank"
href="http://www1.nyc.gov/site/planning/zoning/glossary.page#transit_zone" rel="noopener noreferrer"
>
<FaIcon @icon="external-link-alt" @transform="shrink-3 up-1" />
Appendix I
</a>
</li>
{{/if}}
{{#if layers.appendixj_designated_mdistricts}}
<li>
<a
Expand Down
2 changes: 2 additions & 0 deletions config/environment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ module.exports = function (environment) {
{ id: 'limited-height-districts', visible: false },
{ id: 'mandatory-inclusionary-housing', visible: false },
{ id: 'inclusionary-housing', visible: false },
{ id: 'cho-greater-transit-zone', visible: false },
{ id: 'cho-transit-zones', visible: false },
{ id: 'transit-zones', visible: false },
{ id: 'fresh', visible: false },
{ id: 'low-density-growth-mgmt-areas', visible: false },
Expand Down
8 changes: 4 additions & 4 deletions mirage/static-fixtures/layer-groups.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,17 +451,17 @@ export default {
id: 'transit-zones',
visible: false,
legend: {
label: 'Transit Zones',
label: 'Appendix I',
tooltip:
'Transit-accessible areas where parking is optional for new affordable housing units and special rules apply to existing affordable units',
'Transit-accessible areas where special streetscape and special parking requirements apply.',
infolink:
'https://www1.nyc.gov/site/planning/zoning/glossary.page#transit_zone',
icon: {
type: 'rectangle',
layers: [
{
fill: 'rgba(230, 214, 46, 0.2)',
stroke: 'rgba(230, 214, 46, 0.6)',
fill: 'rgba(49, 151, 149, 0.2)',
stroke: 'rgba(49, 151, 149, 0.6)',
'stroke-dasharray': '1',
},
],
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"@glimmer/component": "^1.1.2",
"@glimmer/tracking": "^1.1.2",
"@mapbox/mapbox-gl-draw": "^1.0.0",
"@nycplanning/ember": "^3.1.0",
"@nycplanning/ember": "^3.2.0",
"@nycplanning/ember-cli-foundation-6-sass": "^0.1.0",
"@nycplanning/ember-cli-nouislider": "^1.3.0",
"@nycplanning/ember-mapbox-gl-draw": "^2.1.0",
Expand Down
Loading
Loading