DevDB - first automated push #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvankrieken
force-pushed
the
fvk-dist-hdb-24Q2
branch
from
8cb731f to
e55de7e
Compare
fvankrieken
force-pushed
the
fvk-dist-hdb-24Q2
branch
from
e55de7e to
f913376
Compare
|
@fvankrieken is this PR something you would like me to pick up? |
|
Nope! |
fvankrieken
force-pushed
the
fvk-dist-hdb-24Q2
branch
from
e50e7c9 to
878caec
Compare
fvankrieken
commented
Jan 10, 2025
| - id: socrata_inactive_included | ||
| type: socrata | ||
| #overrides: | ||
| # display_name: Housing Database Project Level Files - Inactive Included |
There was a problem hiding this comment.
This is one thing that doesn't seem supported right yet, unless I'm missing something @alexrichey
fvankrieken
commented
Jan 10, 2025
| - id: data_dictionary | ||
| custom: | ||
| url: https://s-media.nyc.gov/agencies/dcp/assets/files/excel/data-tools/bytes/Housing_Database_Data_Dictionary.xlsx | ||
| - id: bytes # TODO - multiple bytes sources for socrata dist not supported |
There was a problem hiding this comment.
And this as well - each socrata needs to pull from a specific bytes. Would be a simple enough change to pull from all bytes destinations when packaging, then package up files by ids/names as found/needed. Or only pull the files which are needed from the possible bytes endpoints.
Could chat Monday, might be something I could knock out
alexrichey
approved these changes
Jan 15, 2025
|
Just gonna merge it, so we don't potentially forget. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All are distributed except project level files, standard socrata destination, as the four-four doesn't actually exist. GIS is a little swamped right now but we should follow up with them on what we want to do there. Same for the four-four for the map based on the dataset
Sort of hard to review - sweeping tweaks as I got these pushed out. I made two comments on the project level files that seems worth taking a peek at.