Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fleet): render error cause is swallowed by the logger #3303

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

TBonnin
Copy link
Collaborator

@TBonnin TBonnin commented Jan 14, 2025

No description provided.

@TBonnin TBonnin force-pushed the tbonnin/render-err-cause branch 6 times, most recently from bdb8bb6 to 39fd31d Compare January 14, 2025 15:55
using `errorToObject` when logging operation error in fleet supervisor
@TBonnin TBonnin force-pushed the tbonnin/render-err-cause branch from 39fd31d to d72ed31 Compare January 14, 2025 16:07
@TBonnin TBonnin changed the title test: debugging error.cause not logging properly fix(fleet): render error cause is swallowed by the logger Jan 14, 2025
@TBonnin TBonnin requested a review from a team January 14, 2025 16:07
@TBonnin TBonnin marked this pull request as ready for review January 14, 2025 16:07
Copy link
Collaborator

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird

@TBonnin
Copy link
Collaborator Author

TBonnin commented Jan 14, 2025

Probably related to the winston issue winstonjs/winston#2533

@TBonnin TBonnin merged commit 95dfeda into master Jan 14, 2025
17 checks passed
@TBonnin TBonnin deleted the tbonnin/render-err-cause branch January 14, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants